feat(preprod): Expose snapshot filters in search typeahead#113332
Open
NicoHinderling wants to merge 1 commit intonico/preprod-snapshot-search-filters-backendfrom
Open
feat(preprod): Expose snapshot filters in search typeahead#113332NicoHinderling wants to merge 1 commit intonico/preprod-snapshot-search-filters-backendfrom
NicoHinderling wants to merge 1 commit intonico/preprod-snapshot-search-filters-backendfrom
Conversation
Wire the new snapshot and approval filter keys into the Snapshots tab search bar: - MOBILE_BUILDS_ALLOWED_KEYS: allowlist passed to PreprodSearchBar so the new keys are accepted in the Snapshots tab typeahead. - PREPROD_FIELD_DEFINITIONS (fields/index.ts): descriptions and valueType used by typeahead tooltips. - SENTRY_PREPROD_NUMBER_TAGS / _BOOLEAN_TAGS: classify the new fields so the operator picker offers the correct set (>, <, >=, <=, is/is not). Hide the fields from the left-nav Explore view and Mobile App Size dashboard via HIDDEN_PREPROD_ATTRIBUTES. Those surfaces query EAP directly and the new fields are not written to EAP; queries would return silently empty results. PreprodSearchBar ignores the hidden list when an allowedKeys prop is passed, so the Snapshots tab (which does pass one) keeps the fields visible. Extract PREPROD_IMAGE_FIELDS so the seven image-counter keys have one source of truth across SENTRY_PREPROD_NUMBER_TAGS and HIDDEN_PREPROD_ATTRIBUTES. Depends on the backend PR — the Builds endpoint must accept image_count / images_* / is_approved in its search_config before this PR advertises them.
github-actions
bot
added
the
Scope: Frontend
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires the new snapshot and approval filter keys into the Snapshots tab search bar (under Releases → Snapshots).
MOBILE_BUILDS_ALLOWED_KEYS— allowlist passed toPreprodSearchBar, permits the new keys in the Snapshots tab typeahead.PREPROD_FIELD_DEFINITIONS— descriptions and value types used by typeahead tooltips.SENTRY_PREPROD_NUMBER_TAGS/_BOOLEAN_TAGS— classify the new fields so the operator picker offers the correct set (>,<,>=,<=,is/is not).Hiding from Explore + Dashboards
These fields resolve via the Django Builds endpoint, not EAP. The left-nav Explore view and the Mobile App Size dashboard query EAP directly, where nothing writes these fields — queries there would return silently empty results. Hides them on those surfaces via
HIDDEN_PREPROD_ATTRIBUTES.The Snapshots tab bypasses the hidden list because
PreprodSearchBarsetshiddenKeys = allowedKeys ? undefined : HIDDEN_PREPROD_ATTRIBUTES— passing anallowedKeysprop keeps the fields visible there.Other changes
Extracts
PREPROD_IMAGE_FIELDSto share the seven image-counter keys betweenSENTRY_PREPROD_NUMBER_TAGSandHIDDEN_PREPROD_ATTRIBUTES— otherwise both lists have to stay in sync manually when a new image metric is added.Depends on
Depends on #113331 — the Builds endpoint must accept
image_count,images_*,is_approvedin itssearch_configbefore this PR advertises them.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.