ref(issues): Migrate similar stack trace to react-query#113344
Open
ref(issues): Migrate similar stack trace to react-query#113344
Conversation
Replaces GroupingStore.onFetch/onMerge with useQuery + useMutation against apiOptions. Merge selection (checkbox state, busy-while-merging) lives in the component as a Set instead of on a reflux listener, so item.tsx and toolbar.tsx are now pure prop-driven components. Pulls the scoring transform out of the store into a pure processSimilarItem in types.ts. The similar half of GroupingStore is removed entirely; the merged (unmerge) half stays untouched for groupMerged/. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the Similar Issues tab off the Reflux
GroupingStoreand onto react-query +apiOptions. Selection and merge state live in local React state now, and the in-flight merge drives the row busy state off the mutation'svariablesinstead of a parallel store.Also strips out the similar-only half of
GroupingStoresince nothing else reads from it. Merged/unmerge state stays intact for the Merged Issues tab.First of two stacked PRs - the SimpleTable layout migration follows in #113341.