Skip to content

ref(ci): wait.py, add healthcheck logging#113361

Merged
joshuarli merged 2 commits intomasterfrom
ref-ci-better-xdist-snuba-wait
Apr 17, 2026
Merged

ref(ci): wait.py, add healthcheck logging#113361
joshuarli merged 2 commits intomasterfrom
ref-ci-better-xdist-snuba-wait

Conversation

@joshuarli
Copy link
Copy Markdown
Member

hard to tell what went wrong with https://github.com/getsentry/sentry/actions/runs/24583849686/job/71888363725 until we have more logging. devservices logs only prints stdout/err logs which do not include healthcheck logs which is where we failed

also wait.sh -> wait.py for less brittleness, and bootstrap-snuba.py now waits for snuba-snuba-1 to be healthy before starting parallel ClickHouse bootstraps

@joshuarli joshuarli requested a review from mchen-sentry April 17, 2026 21:44
@joshuarli joshuarli requested review from a team as code owners April 17, 2026 21:44
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 17, 2026
Comment thread .github/actions/setup-devservices/wait.py
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ad012bc. Configure here.

Comment thread .github/actions/setup-devservices/wait.py
@joshuarli joshuarli enabled auto-merge (squash) April 17, 2026 22:03
@joshuarli joshuarli merged commit a2d09d0 into master Apr 17, 2026
55 checks passed
@joshuarli joshuarli deleted the ref-ci-better-xdist-snuba-wait branch April 17, 2026 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants