fix(cmdk): Do not fire selections on Tab key press#113381
Open
fix(cmdk): Do not fire selections on Tab key press#113381
Conversation
Tab key events in the command palette input were triggering item selection, the same as Enter. Tab should only move focus — not activate items. Refs DE-1064 Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Frontend
rbro112
approved these changes
Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tab key events in the command palette input were calling
onActionSelection,causing the focused item to be activated whenever the user pressed Tab (e.g.
to move focus away from the palette). Only Enter should trigger item selection.
Also removes the now-unnecessary comment about Shift+Tab and cleans up the
shiftKeyguard that was compensating for the Tab case.Refs DE-1064