chore(insights): remove starfish-view feature flag#113435
Merged
Conversation
The starfish-view flag was declared but not actually gating any real behavior — it appeared in batch_has() feature name lists for organization_events and organization_events_stats endpoints but the result was never consumed. Remove the declaration, the listings in those endpoints, and the corresponding setUp() entries in the span indexed and span metrics tests.
nikkikapadia
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
starfish-viewfeature flag. The flag was declared intemporary.pybut was not actually gating any real behavior — it appeared inbatch_has()feature name lists inorganization_eventsandorganization_events_statsendpoints but the returned value was never consumed downstream.Cleanup after the feature is fully released (effectively always-on).
src/sentry/features/temporary.pyget_featuresmethodssetUp()entries in the span indexed and span metrics test filesCompanion PR (flagpole config removal): https://github.com/getsentry/sentry-options-automator/pull/7359