feat(dashboards): Add UI to view dashboard revisions by skaasten · Pull Request #113441 · getsentry/sentry

skaasten · 2026-04-20T16:01:58Z

Adds a clock icon button to the dashboard controls toolbar that opens a modal listing the revision history for the current dashboard. Each row shows the revision title, who created it, and a relative timestamp.

The button is gated behind the dashboards-revisions feature flag and hidden for prebuilt and default-overview dashboards (which have no stored revisions). The revisions endpoint is not called until the modal is opened — no eager fetch on page load.

Refs DAIN-1545

linear-code · 2026-04-20T16:02:12Z

DAIN-1545 UI to view dashboard revisions

cursor

Cursor Bugbot has reviewed your changes and found 3 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit ce551f2. Configure here.}

DominikB2014 · 2026-04-20T19:16:37Z

+    {
+      staleTime: 30_000,
+      enabled,
+    }


When we actually restore the revision, or create a new one, it would be a good idea to invalidate the cache for the next request to this endpoint.

Okay, added invalidation on edits to the dashboard, which would make a new revision. I'll do the same when we allow restore.

DominikB2014 · 2026-04-20T19:17:35Z

+export function makeDashboardRevisionsQueryKey(orgSlug: string, dashboardId: string) {
+  return [
+    getApiUrl('/organizations/$organizationIdOrSlug/dashboards/$dashboardId/revisions/', {
+      path: {organizationIdOrSlug: orgSlug, dashboardId},
+    }),
+  ] as const;
+}
+


I would move this into the file with the hook as it's directly related to that and only used there

DominikB2014 · 2026-04-20T19:19:07Z

+  enabled = true,
+}: UseDashboardRevisionsOptions) {
+  const organization = useOrganization();
+  return useApiQuery<DashboardRevision[]>(


I think thew new pattern is to use useQuery + apiOptions and not useApiQuery

nikkikapadia · 2026-04-20T19:19:06Z

+  );
+}
+
+function RevisionList({revisions}: {revisions: DashboardRevision[]}) {


instead of using the <Table> component here we have a <SimpleTable> core component that i think would be better to use. Not sure if the table is going to stick around or continue to be formatted like this but I still think it's good practice to use the design system!

Thank you - it looks much nicer with that change!

Adds a clock icon button to the dashboard controls toolbar (gated behind the dashboards-revisions feature flag) that opens a modal listing all revisions for the current dashboard. Each row shows the revision title, who created it, and a relative timestamp via TimeSince. The revisions endpoint is only called when the modal is opened, not on page load. Refs DAIN-1545 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Covers: feature flag gate, prebuilt/default-overview exclusions, lazy API fetching (endpoint not called until modal opens), revision list rendering, createdBy fallbacks, and the empty state. Also moves the feature flag check inside the component for testability, removing the Feature wrapper from controls.tsx. Refs DAIN-1545 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- Show an error state (Alert danger) when the revisions API request fails instead of silently falling through to the empty state - Move typography (font-weight, font-size, color) out of the Th styled component into Text primitives, keeping styled components layout-only - Remove unused orgSlug prop from DashboardRevisionsModal Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Adds a muted grey tag to revisions created as a pre-restore snapshot. The source type is narrowed to 'edit' | 'pre-restore' to match the updated backend value. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- Switch useDashboardRevisions to useQuery + apiOptions (new preferred pattern) - Move DashboardRevision type and query options factory to the hook file since they are only used there; export for future cache invalidation - Replace custom styled table with SimpleTable core component Co-Authored-By: Claude Sonnet 4 <noreply@example.com>

Remove the exported makeDashboardRevisionsQueryOptions helper since nothing uses it yet — knip flagged it as an unused export. The query options can be exported when a restore action needs to invalidate the cache. Co-Authored-By: Claude Sonnet 4 <noreply@example.com>

After any successful updateDashboard call, invalidate the revisions query so the next modal open reflects the newly created revision immediately rather than serving stale cached data. Co-Authored-By: Claude Sonnet 4 <noreply@example.com>

nikkikapadia

lgtm 😌

DominikB2014

lgtm, just one suggestion on the flag conditional!

DominikB2014 · 2026-04-21T14:48:52Z

              </Tooltip>
            )}
            {renderEditButton(hasFeature)}
+            <DashboardRevisionsButton dashboard={dashboard} />


I personally think it's cleaner to conditionally render the button here if the feature is available. In general i think feature checks should happen as early as possible for a few reasons

minimizes risk, less of your featured code is ran

consistent with the codebase (the line below checks hasFeature to render a tooltip)

Easier to read, you don't have to jump into the DashboardRevisionsButton component to understand it's conditionally rendered.

Agree - I'll update it thanks!

Gate the DashboardRevisionsButton behind a <Feature> component in controls.tsx. Validity checks (default-overview, prebuilt dashboards) stay inside the component with corresponding tests. Co-Authored-By: Claude Sonnet 4 <noreply@example.com>

…s absent Co-Authored-By: Claude Sonnet 4 <noreply@example.com>

github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 20, 2026

vercel Bot deployed to Preview April 20, 2026 16:03 View deployment

skaasten marked this pull request as ready for review April 20, 2026 16:17

skaasten requested a review from a team as a code owner April 20, 2026 16:17

cursor Bot reviewed Apr 20, 2026

View reviewed changes

Comment thread static/app/views/dashboards/dashboardRevisions.tsx Outdated

Comment thread static/app/views/dashboards/dashboardRevisions.tsx Outdated

Comment thread static/app/views/dashboards/dashboardRevisions.tsx

vercel Bot deployed to Preview April 20, 2026 16:30 View deployment

vercel Bot deployed to Preview April 20, 2026 16:49 View deployment

DominikB2014 reviewed Apr 20, 2026

View reviewed changes

nikkikapadia reviewed Apr 20, 2026

View reviewed changes

vercel Bot deployed to Preview April 20, 2026 19:55 View deployment

vercel Bot deployed to Preview April 20, 2026 20:07 View deployment

vercel Bot deployed to Preview April 20, 2026 20:16 View deployment

skaasten and others added 8 commits April 21, 2026 09:47

ref(dashboards): Move revisions button before Add Widget

669661d

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat(dashboards): Show pre-restore badge on revision list

361081d

Adds a muted grey tag to revisions created as a pre-restore snapshot. The source type is narrowed to 'edit' | 'pre-restore' to match the updated backend value. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

skaasten force-pushed the shaunkaasten/dain-1545-ui-to-view-dashboard-revisions branch from ce1de0c to 716350a Compare April 21, 2026 13:53

vercel Bot deployed to Preview April 21, 2026 13:54 View deployment

skaasten requested review from DominikB2014 and nikkikapadia April 21, 2026 14:22

nikkikapadia approved these changes Apr 21, 2026

View reviewed changes

DominikB2014 approved these changes Apr 21, 2026

View reviewed changes

vercel Bot deployed to Preview April 21, 2026 15:00 View deployment

ref(dashboards): Hide revisions button when dashboards-edit feature i…

f6600f6

…s absent Co-Authored-By: Claude Sonnet 4 <noreply@example.com>

vercel Bot deployed to Preview April 21, 2026 15:11 View deployment

skaasten merged commit 48b6c48 into master Apr 21, 2026
65 checks passed

skaasten deleted the shaunkaasten/dain-1545-ui-to-view-dashboard-revisions branch April 21, 2026 15:21

sentry-release-bot Bot mentioned this pull request Apr 22, 2026

publish: getsentry/sentry@26.4.1 getsentry/publish#7907

Closed

3 tasks

Uh oh!

Conversation

skaasten commented Apr 20, 2026

Uh oh!

linear-code Bot commented Apr 20, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nikkikapadia left a comment

Choose a reason for hiding this comment

Uh oh!

DominikB2014 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants