ref(ci): tolerate action-download flakes on collect-test-data#113453
Merged
mchen-sentry merged 1 commit intomasterfrom Apr 20, 2026
Merged
ref(ci): tolerate action-download flakes on collect-test-data#113453mchen-sentry merged 1 commit intomasterfrom
mchen-sentry merged 1 commit intomasterfrom
Conversation
Outer continue-on-error so transient GitHub runner prepare-phase 404s emit a warning instead of red-failing the job. Test collection is telemetry-only; we don't want it blocking CI signal. DI-1861
github-actions
Bot
added
the
Scope: Backend
mchen-sentry
changed the title
armenzg
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we're seeing transient Github Actions infra flakes in the collect test data step which is failing the job.
It's somewhat inconvenient to add retry logic as it's the prepare phase here (using a retry action would run into the same download problem; shell scripts inside
runonly happen after the step's ownpreparephase which is failing here), but fundamentally test collection is telemetry and not test correctness so we shouldn't fail the workflow for this.The inner composite step already has continue-on-error, but that only covers the step's run phase. When tarball downloads during the action prepare phase 404 (which happens before any step runs), the attribute never gets a chance to apply. Putting it on the outer step catches the prepare-phase failures too.
With this change, the step itself will be marked as failed in the UI with a warning icon, but the job conclusion and run stays green.