fix(dashboards): Guard getTimeseriesSortOptions call in widget builder#113467
Merged
edwardgou-sentry merged 1 commit intomasterfrom Apr 21, 2026
Conversation
github-actions
Bot
added
the
Scope: Frontend
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
gggritso
reviewed
Apr 20, 2026
Member
gggritso
left a comment
gggritso
left a comment
There was a problem hiding this comment.
🤔 I'm wondering if it'd be better for Issues to specify that getTimeseriesSortOptions always return [], and then the types could be simplified. We'd say that getTimeseriesSortOptions is required and could remove all the checks?
The issues dataset config did not implement getTimeseriesSortOptions, causing a runtime crash in the widget builder sort-by selector. Add a no-op implementation returning an empty record to the issues config and make the method required on the DatasetConfig interface so this class of error is caught at compile time.
edwardgou-sentry
force-pushed
the
edwardgou/dain-1510-widget-builder-partially-crashes-due-to-missing-time-series
branch
from
31ed0e7 to
69421f9
Compare
gggritso
approved these changes
Apr 21, 2026
edwardgou-sentry
deleted the
edwardgou/dain-1510-widget-builder-partially-crashes-due-to-missing-time-series
branch
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes DAIN-1510
issuesdataset config did not implementgetTimeseriesSortOptions, causing aN.getTimeseriesSortOptions is not a functioncrash in the widget builder's sort-by selector.() => ({})) to the issues config.getTimeseriesSortOptionsrequired on theDatasetConfiginterface so missing implementations are caught at compile time instead of crashing at runtime.