fix(releases): Remove unused statsPeriod query parameter#113482
Merged
fix(releases): Remove unused statsPeriod query parameter#113482
Conversation
Navigating from the releases list to a release detail was briefly showing statsPeriod in the URL and then stripping it, causing an extra rerender. Two things were writing it in. The release list's "View" link forwarded extractSelectionParameters(location.query), which includes statsPeriod, so the detail page mounted with it already in the URL. Then PageFiltersContainer's init would also write it back after the detail page's cleanup effect stripped it — a little ping-pong. Pass skipInitializeUrlParams to PageFiltersContainer on the detail page (it doesn't use global datetime anyway — it has its own release-bounded range), and only forward environment + project from the list link. The existing cleanup effect stays as a guard for direct/shared links. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
shashjar
approved these changes
Apr 21, 2026
natemoo-re
pushed a commit
that referenced
this pull request
Apr 21, 2026
Navigating from the releases list to a release detail briefly showed `statsPeriod` in the URL before stripping it, causing an extra rerenders and i think queries? Remove from the link passing it in and add a prop that prevents adding it. Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Navigating from the releases list to a release detail briefly showed
statsPeriodin the URL before stripping it, causing an extra rerenders and i think queries?Remove from the link passing it in and add a prop that prevents adding it.