Skip to content

fix(releases): Remove unused statsPeriod query parameter#113482

Merged
scttcper merged 1 commit intomasterfrom
scttcper/release-details-statsperiod
Apr 21, 2026
Merged

fix(releases): Remove unused statsPeriod query parameter#113482
scttcper merged 1 commit intomasterfrom
scttcper/release-details-statsperiod

Conversation

@scttcper
Copy link
Copy Markdown
Member

@scttcper scttcper commented Apr 20, 2026

Navigating from the releases list to a release detail briefly showed statsPeriod in the URL before stripping it, causing an extra rerenders and i think queries?

Remove from the link passing it in and add a prop that prevents adding it.

Navigating from the releases list to a release detail was briefly
showing statsPeriod in the URL and then stripping it, causing an extra
rerender.

Two things were writing it in. The release list's "View" link forwarded
extractSelectionParameters(location.query), which includes statsPeriod,
so the detail page mounted with it already in the URL. Then
PageFiltersContainer's init would also write it back after the detail
page's cleanup effect stripped it — a little ping-pong.

Pass skipInitializeUrlParams to PageFiltersContainer on the detail page
(it doesn't use global datetime anyway — it has its own release-bounded
range), and only forward environment + project from the list link. The
existing cleanup effect stays as a guard for direct/shared links.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 20, 2026
@scttcper scttcper changed the title fix(releases): Stop statsPeriod pop-in on release details page fix(releases): Remove unused statsPeriod query parameter Apr 20, 2026
@scttcper scttcper marked this pull request as ready for review April 21, 2026 00:41
@scttcper scttcper requested a review from a team as a code owner April 21, 2026 00:41
@scttcper scttcper requested a review from a team April 21, 2026 00:41
@scttcper scttcper merged commit 26af309 into master Apr 21, 2026
68 checks passed
@scttcper scttcper deleted the scttcper/release-details-statsperiod branch April 21, 2026 16:54
natemoo-re pushed a commit that referenced this pull request Apr 21, 2026
Navigating from the releases list to a release detail briefly showed
`statsPeriod` in the URL before stripping it, causing an extra rerenders
and i think queries?

Remove from the link passing it in and add a prop that prevents adding
it.

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants