fix(alerts): Make everything vertical aligned#113532
Merged
priscilawebdev merged 9 commits intomasterfrom Apr 22, 2026
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
Member
|
@priscilawebdev iirc one of these pages renders breadcrumbs which we should render to the topbar slot. 
in the above example, breadcrumbs should render to the page frame, but the title should stay where it is (opposite of the screenshot) |
Member
Author
|
Merge origin/master into the alert content alignment branch and keep both the page-frame top bar updates from master and the layout/footer alignment changes from this branch. This preserves the new title slot behavior while keeping the alert form body and sticky footer aligned with the page frame. Co-Authored-By: Codex GPT-5 <noreply@openai.com>
Keep the upstream hasPageFrameFeature naming in the alert views and the shared footer helper. This avoids introducing a parallel boolean name while preserving the conflict resolution behavior. Co-Authored-By: Codex GPT-5 <noreply@openai.com>
Document why the alert footer subtracts two xl gutters from maxWidth in the page-frame layout. This makes the width calculation easier to read during review and future edits. Co-Authored-By: Codex GPT-5 <noreply@openai.com>
priscilawebdev
changed the title
natemoo-re
approved these changes
Apr 22, 2026
Member
natemoo-re
left a comment
natemoo-re
left a comment
There was a problem hiding this comment.
Looks good! The Monitors views also need the same treatment.
Member
There was a problem hiding this comment.
Not related to this change, but this is a good candidate for a shared layout abstraction to avoid duplicating logic in /edit.tsx and /new.tsx
priscilawebdev
deleted the
priscilawebdev/fix/new-alert-content-alignment
branch
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
After