fix(forms): propagate request field errors in autosave

[sentry-junior]

summary

• pass RequestError instances through AutoSaveForm error handling instead of always replacing them with Failed to save
• keep the generic fallback for non-request failures
• add a regression test covering DRF-style field validation responses

testing

• CI=true pnpm test static/app/components/core/form/autoSaveForm.spec.tsx --runInBand

Refs DE-1181

[linear-code]

DE-1181 Propagate DRF field validation errors in AutoSaveForm

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 91572ba. Configure here.}

[cursor]

Silent error when RequestError lacks matching field errors

High Severity

When a RequestError is thrown but its responseJSON doesn't contain a key matching the form's field name (e.g., a 500 error with {detail: "Internal server error"}, or a 403 with no field-level errors), setFieldErrors silently returns without setting any error. The user gets no feedback at all. Previously, every error produced a "Failed to save" message. The fallback generic message is needed when setFieldErrors extracts zero matching field errors from a RequestError.

 

^{Reviewed by Cursor Bugbot for commit 91572ba. Configure here.}

[sentry]

Bug: The new error handling for RequestError can lead to silent failures. The setFieldErrors function won't show an error for network issues or API responses with non-field errors.
_{Severity: HIGH}

Suggested Fix

After attempting to set errors from a RequestError, check if any errors were actually set. If no specific field errors could be mapped from the response, fall back to displaying a generic error message like t('Failed to save'). This ensures the user is always notified of a save failure, restoring the previous behavior for unhandled error types.

Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: static/app/components/core/form/autoSaveForm.tsx#L200-L206

Potential issue: In `autoSaveForm.tsx`, `RequestError` instances are now passed directly
to the `setFieldErrors` function. However, `setFieldErrors` only displays an error if
the `RequestError` contains a `responseJSON` with keys that match the form's field
names. This means that for common API failure scenarios, such as network errors, 500
responses without a JSON body, or responses with non-field errors (e.g., `{"detail":
"..."}`), no error message will be shown to the user. This creates a silent failure
where the user may believe their changes were saved when they were not, which is a
regression from the previous behavior that showed a generic failure message.

_{Did we get this right? 👍 / 👎 to inform future reviews.}

[TkDodo]

I’ll tackle a proper fix with DE-1180

[TkDodo]

superseded by:

• fix(scraps): propagate drf field validation errors in autoSaveForm #113644