Skip to content

ref(page-frame): Compact editable titles in topbar for dashboards and monitors#113574

Merged
JonasBa merged 4 commits intomasterfrom
jb/de-1137
Apr 21, 2026
Merged

ref(page-frame): Compact editable titles in topbar for dashboards and monitors#113574
JonasBa merged 4 commits intomasterfrom
jb/de-1137

Conversation

@JonasBa
Copy link
Copy Markdown
Member

@JonasBa JonasBa commented Apr 21, 2026

Add compact variant to editable text and use it when the editable text is present in the page frame header

Fixes DE-1137, DE-1183

JonasBa and others added 2 commits April 21, 2026 11:07
Add a `variant="compact"` to `EditableText` that removes the fixed
38px line-height and dashed bottom border so the title inherits sizing
from its context. Apply it in `DashboardTitle` when the page-frame
flag is active, preventing the title from rendering oversized inside
the breadcrumb row.

Refs DE-1130
Co-Authored-By: Claude <noreply@anthropic.com>
When the page-frame flag is active, remove the dashed bottom border and
drop the hardcoded Layout.Title font sizes so the editable view title
inherits sizing from its context, matching the treatment applied to the
dashboard title.

Refs DE-1130
Co-Authored-By: Claude <noreply@anthropic.com>
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 21, 2026
@getsentry getsentry deleted a comment from linear-code Bot Apr 21, 2026
JonasBa and others added 2 commits April 21, 2026 11:16
@JonasBa JonasBa changed the title ref(page-frame): Compact editable titles in topbar for dashboards and issue views ref(page-frame): Compact editable titles in topbar for dashboards and monitors Apr 21, 2026
@JonasBa JonasBa marked this pull request as ready for review April 21, 2026 18:18
@JonasBa JonasBa requested review from a team as code owners April 21, 2026 18:18
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 3175ab5. Configure here.

Comment thread static/app/components/editableText.tsx
@JonasBa JonasBa merged commit 591d289 into master Apr 21, 2026
68 checks passed
@JonasBa JonasBa deleted the jb/de-1137 branch April 21, 2026 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants