fix(slack): Prompt unlinked users to link identity for dashboards URLs#113590
Merged
DominikB2014 merged 6 commits intomasterfrom Apr 29, 2026
Merged
Conversation
Add LinkType.DASHBOARDS to the identity-prompt feature_flag map so users without a linked Slack identity get the "Link your Slack identity to Sentry" prompt when they paste a dashboard widget URL — matching the existing behavior for discover and explore URLs. The prompt continues to gate on the associated feature flag (organizations:dashboards-widget-unfurl), so orgs without the feature see no prompt. Also make the halt message generic instead of hardcoded to "Discover link". Refs DAIN-1569 Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ee67e28. Configure here.
The prompt text hardcoded "unfurl Discover charts" but the same prompt now fires for explore and dashboards URLs too. Drop the Discover-specific wording. Co-Authored-By: Claude <noreply@anthropic.com>
…our-identity-message-shows-up
…our-identity-message-shows-up
Without this, `_validate_identity()` is gated on discover/explore links in `SlackEventRequest.validate_integration`, so dashboards-only events never resolve `slack_request.user`. The identity-prompt branch added for dashboards in the previous commit would then fire for every share (linked or not), since `has_identity` stays `False`. Adds `has_dashboard_links` and includes it in the gate so the linked user's identity is resolved and the unfurl proceeds with their access.
narsaynorath
approved these changes
Apr 29, 2026
DominikB2014
deleted the
dominikbuszowiecki/dain-1569-ensure-link-your-identity-message-shows-up
branch
3 tasks
cleptric
pushed a commit
that referenced
this pull request
May 5, 2026
#113590) Resolves dashboard identity for `link_shared` events and prompts unlinked users to link, matching discover/explore behavior. Refs DAIN-1569 --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves dashboard identity for
link_sharedevents and prompts unlinked users to link, matching discover/explore behavior.Refs DAIN-1569