Conversation
The atomic transaction in the revision restore endpoint only writes `Dashboard` and `DashboardRevision` rows, but was passing `DashboardTombstone` to `router.db_for_write()`. It was harmless since all three share a DB, but misleading — the hint should reflect what the transaction actually writes. This appears to have been copy-pasted from the details endpoint's PUT, where the transaction did also write a tombstone row. Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Backend
gggritso
deleted the
georgegritsouk/fix-tombstone-router-hint-in-revision-restore
branch
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This stuck out to me while looking at some related code.
DashboardTombstoneis not long for this world, and it seemed strange that it's used as the hint here, since it's not the model being changed! I figured now's a good time to remove it.