Skip to content

fix(explorer): use new isDrawerOpen state for more accurate open/closed tracking#113639

Merged
aliu39 merged 5 commits intomasterfrom
aliu/fix-isopen
Apr 22, 2026
Merged

fix(explorer): use new isDrawerOpen state for more accurate open/closed tracking#113639
aliu39 merged 5 commits intomasterfrom
aliu/fix-isopen

Conversation

@aliu39
Copy link
Copy Markdown
Member

@aliu39 aliu39 commented Apr 22, 2026

passes regression tests in useSeerExplorerDrawer.spec

natemoo-re and others added 3 commits April 21, 2026 20:53
Update dependency array from [context, callerId] to [context.openDrawer, callerId]
to restore referential stability. The entire context object is recreated on every
render, but we only need context.openDrawer, preventing unnecessary re-renders.

Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
@aliu39 aliu39 requested a review from a team as a code owner April 22, 2026 05:32
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 22, 2026
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit b04a943. Configure here.

Comment thread static/app/views/seerExplorer/components/drawer/useSeerExplorerDrawer.tsx Outdated
Base automatically changed from nm/ui/scope-usedrawer to master April 22, 2026 13:48
@aliu39 aliu39 requested review from a team as code owners April 22, 2026 13:48
@aliu39 aliu39 disabled auto-merge April 22, 2026 15:31
@aliu39 aliu39 merged commit a3677c8 into master Apr 22, 2026
64 checks passed
@aliu39 aliu39 deleted the aliu/fix-isopen branch April 22, 2026 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants