Skip to content

fix(logs): remove duplicate main element on logs page#113649

Merged
priscilawebdev merged 2 commits intomasterfrom
priscila/fix/empty-header-and-duplicate-main
Apr 22, 2026
Merged

fix(logs): remove duplicate main element on logs page#113649
priscilawebdev merged 2 commits intomasterfrom
priscila/fix/empty-header-and-duplicate-main

Conversation

@priscilawebdev
Copy link
Copy Markdown
Member

@priscilawebdev priscilawebdev commented Apr 22, 2026

Before
image

After
Screenshot 2026-04-22 at 12 04 55

ViewportConstrainedPage wrapped its content in Layout.Page, which
renders a <main>. OrganizationLayout already renders a Layout.Page at
the route root, so the logs page produced two <main> elements when
page-frame was active. Switch the inner wrapper to Stack (a <div>) with
the same flex/background styles, leaving the outer Layout.Page as the
sole <main>.

Co-Authored-By: Claude <noreply@anthropic.com>
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 22, 2026
The outer Layout.Page in OrganizationLayout already applies
background="primary" in page-frame mode, and in legacy mode no
background was set. Dropping the explicit background avoids a redundant
override in page-frame and a subtle visual regression in legacy mode.

Co-Authored-By: Claude <noreply@anthropic.com>
@priscilawebdev priscilawebdev marked this pull request as ready for review April 22, 2026 10:11
@priscilawebdev priscilawebdev requested a review from a team as a code owner April 22, 2026 10:11
@priscilawebdev priscilawebdev requested a review from a team April 22, 2026 10:11
@priscilawebdev priscilawebdev merged commit a247c2b into master Apr 22, 2026
66 checks passed
@priscilawebdev priscilawebdev deleted the priscila/fix/empty-header-and-duplicate-main branch April 22, 2026 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants