fix(logs): remove duplicate main element on logs page#113649
Merged
priscilawebdev merged 2 commits intomasterfrom Apr 22, 2026
Merged
fix(logs): remove duplicate main element on logs page#113649priscilawebdev merged 2 commits intomasterfrom
priscilawebdev merged 2 commits intomasterfrom
Conversation
ViewportConstrainedPage wrapped its content in Layout.Page, which renders a <main>. OrganizationLayout already renders a Layout.Page at the route root, so the logs page produced two <main> elements when page-frame was active. Switch the inner wrapper to Stack (a <div>) with the same flex/background styles, leaving the outer Layout.Page as the sole <main>. Co-Authored-By: Claude <noreply@anthropic.com>
The outer Layout.Page in OrganizationLayout already applies background="primary" in page-frame mode, and in legacy mode no background was set. Dropping the explicit background avoids a redundant override in page-frame and a subtle visual regression in legacy mode. Co-Authored-By: Claude <noreply@anthropic.com>
TkDodo
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before

After
