Skip to content

feat(seer agent): add esc as a way to stop thinking#113734

Merged
sehr-m merged 1 commit intomasterfrom
sehrm/esc-pauses-thinking-seer-agent
Apr 22, 2026
Merged

feat(seer agent): add esc as a way to stop thinking#113734
sehr-m merged 1 commit intomasterfrom
sehrm/esc-pauses-thinking-seer-agent

Conversation

@sehr-m
Copy link
Copy Markdown
Member

@sehr-m sehr-m commented Apr 22, 2026

To fit with convention, esc is now a hotkey for stopping thinking in the seer explorer drawer. The drawer still uses polling so if pausing is done before the thinking starts nothing will be returned, otherwise it will be the last message returned from the poll.

@sehr-m sehr-m requested a review from a team as a code owner April 22, 2026 20:19
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 22, 2026
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 038422d. Configure here.

handleSend();
} else if (e.key === 'Escape' && canInterrupt && !waitingForInterrupt) {
e.preventDefault();
interruptRun();
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing stopPropagation causes drawer to close on Escape

High Severity

The Escape key handler calls e.preventDefault() but not e.stopPropagation(). The drawer documentation states it "always closes on Escape in both modes," so pressing Escape to interrupt thinking will also close the drawer. The existing Escape handler in explorerMenu.tsx correctly uses both e.preventDefault() and e.stopPropagation() to avoid this exact problem.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 038422d. Configure here.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cursoragent add e.stopPropagation() here

Copy link
Copy Markdown
Contributor

@cursor cursor Bot Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! The fix has been applied successfully. The change adds e.stopPropagation() on line 231, which prevents the Escape key event from bubbling up to the drawer component that would otherwise close the drawer. This matches the pattern used in the existing explorerMenu.tsx file.

Summary

I've successfully added e.stopPropagation() to the Escape key handler in the Seer Explorer drawer. The fix ensures that when users press Escape to interrupt the thinking process, the drawer won't close unexpectedly.

Changes made:

  • Added e.stopPropagation() on line 231 in explorerDrawerContent.tsx to prevent the Escape key event from bubbling up to the drawer's close handler
  • The fix follows the same pattern used in explorerMenu.tsx for handling Escape key presses

Commit: fix(seer agent): add stopPropagation to prevent drawer close on interrupt

The changes have been committed and pushed to the branch sehrm/esc-pauses-thinking-seer-agent.

Open in Web Open in Cursor 

@sehr-m sehr-m merged commit 3fcbffe into master Apr 22, 2026
66 checks passed
@sehr-m sehr-m deleted the sehrm/esc-pauses-thinking-seer-agent branch April 22, 2026 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants