Skip to content

fix(seer-agent): fix showActions on hover and cleanup broken focusedBlockIndex state#113739

Merged
aliu39 merged 6 commits intomasterfrom
aliu/fix-actions
Apr 22, 2026
Merged

fix(seer-agent): fix showActions on hover and cleanup broken focusedBlockIndex state#113739
aliu39 merged 6 commits intomasterfrom
aliu/fix-actions

Conversation

@aliu39
Copy link
Copy Markdown
Member

@aliu39 aliu39 commented Apr 22, 2026

also fixes block navigation, disabling it when input is focused

deletes block keyboard nav for now, except pressing enter

@aliu39 aliu39 requested a review from a team as a code owner April 22, 2026 20:44
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 22, 2026
if (focusedBlockIndex !== -1) {
setFocusedBlockIndex(-1);
if (hoveredBlockIndex !== -1) {
setHoveredBlockIndex(-1);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hover state cleared by typing, won't restore without mouse re-enter

Medium Severity

handleInputChange resets hoveredBlockIndex to -1 whenever the user types, which was logic designed for the old keyboard-focused focusedBlockIndex paradigm. Now that the state is driven by mouse hover, if a user's mouse is resting over a block while they type in the textarea, each keystroke clears the hover state (hiding action buttons). Since onMouseEnter only fires when the cursor enters an element (not while stationary inside it), the hover state won't restore until the mouse physically leaves and re-enters the block. The textareaRef.current?.focus() call is also redundant here since the textarea is already focused (the user is typing in it).

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 2c73298. Configure here.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

theres no way to focus the input now without clicking it

Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit b88fb59. Configure here.

blocks: Block[];
focusedBlockIndex: number;
isOpen: boolean;
setFocusedBlockIndex: (index: number) => void;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused required props in useBlockNavigation hook interface

Low Severity

UseBlockNavigationProps still declares blockRefs and blocks as required props, and isMinimized and onNavigate as optional props, but the hook body no longer destructures or uses any of them. The call site in explorerDrawerContent.tsx still passes all four. This is dead code left over from removing the arrow-key navigation logic.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit b88fb59. Configure here.

@aliu39 aliu39 merged commit 42fc7a4 into master Apr 22, 2026
65 checks passed
@aliu39 aliu39 deleted the aliu/fix-actions branch April 22, 2026 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants