fix(detectors): Clarify Detector status vs enabled; update code accordingly

[kcons]

We've been blurring the distinction between plan disabling of Detectors and snooze disabling.
This change aims to clarify the distinction, and update existing code that cares about one or the other to only update the field they should be modifying.

Note that code and tests in getsentry also use this code, so a legacy alias in retained here, and there is another PR (https://github.com/getsentry/getsentry/pull/20011) to update the tests in that repo to still pass with this PR applied.

[saponifi3d]

high level this makes sense, is the plan to go back and update the detector selection in processing separately?

[saponifi3d]

should we update the get_queryset to automatically filter out the disabled detectors? these seem like they're not recoverable directly by a user, but would require some other action before being re-enabled.

that or we should filter detectors that are disabled in process_data_sources -- i'd lean more towards the manager so it's consistent, even outside of our primary use cases.

[kcons]

I'm unsure. At present, this distinction is only really relevant to Metric Detectors, and we already unsubscribe those on plan change and filtering the disallowed ones in the APIs, so the difference behaviorally isn't substantial.
But, filtering out disabled detectors by default makes all of that much cheaper, because we only really have to evaluate it once and cache it, so I do want to go that way.
I'm thinking of going further as a follow-up; for now, I'm trying to just correct current behavioral patterns enough to fix the getsentry-side processing.

But it does make sense to make more of the general code aware of this by default; we want new uses of this status work automatically.

[saponifi3d]

🎉 - glad we can reuse this field instead of adding a new one!

[github-actions]

Backend Test Failures

Failures on b5df693 in this run:

tests/sentry/workflow_engine/endpoints/test_organization_detector_details.py::OrganizationDetectorDetailsPutTest::test_disable_detector — log

[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/workflow_engine/endpoints/test_organization_detector_details.py:551: in test_disable_detector
    assert detector.status == ObjectStatus.DISABLED
E   assert 0 == 1
E    +  where 0 = <Detector at 0x7fcd36a7b520: id=729>.status
E    +  and   1 = ObjectStatus.DISABLED

tests/sentry/workflow_engine/endpoints/test_organization_detector_details.py::OrganizationDetectorDetailsPutTest::test_enable_detector — log

[gw1] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/workflow_engine/endpoints/test_organization_detector_details.py:570: in test_enable_detector
    assert detector.status == ObjectStatus.ACTIVE
E   assert 1 == 0
E    +  where 1 = <Detector at 0x7f40e58e3040: id=832>.status
E    +  and   0 = ObjectStatus.ACTIVE

[kcons]

getsentry side, required for cross-repo tests to pass: https://github.com/getsentry/getsentry/pull/20011