Skip to content

ref(tsc): remove getResponseHeader from useApiQuery#113775

Merged
TkDodo merged 3 commits intomasterfrom
tkdodo/ref/remove-getResponseHeader-from-useApiQuery
Apr 23, 2026
Merged

ref(tsc): remove getResponseHeader from useApiQuery#113775
TkDodo merged 3 commits intomasterfrom
tkdodo/ref/remove-getResponseHeader-from-useApiQuery

Conversation

@TkDodo
Copy link
Copy Markdown
Collaborator

@TkDodo TkDodo commented Apr 23, 2026

If you need response headers, apiOptions includes them in the result ({json, headers}) when used with select: selectJsonWithHeaders. AGENTS.md already knows this.

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 23, 2026
@TkDodo TkDodo marked this pull request as ready for review April 23, 2026 08:09
@TkDodo TkDodo requested review from a team as code owners April 23, 2026 08:09
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was all dead code - no one ever passed tagsQueryResults into this component.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice clean up! 🧼

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice clean up! 🧼

@TkDodo TkDodo merged commit ce8afb7 into master Apr 23, 2026
65 checks passed
@TkDodo TkDodo deleted the tkdodo/ref/remove-getResponseHeader-from-useApiQuery branch April 23, 2026 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants