feat(explore): Move to a sticky header layout#113780
Merged
nsdeschenes merged 7 commits intomasterfrom Apr 27, 2026
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
ViewportConstrainedPage applies overflow: hidden and contain: size, which prevented the ExploreBodySearch sticky positioning on the logs page from working — the constrained container has no scroll for the sticky element to participate in. Move ViewportConstrainedPage inward to wrap only the body region (sidebar + content) instead of the entire page shell, leaving the search/filter row in the page's normal scroll context. This matches the metrics page layout and preserves the table-expand viewport behavior. Co-Authored-By: Claude <noreply@anthropic.com>
The interface is no longer used outside useTableExpando.tsx after the sticky header refactor. Drop the export to satisfy knip. Co-Authored-By: Claude <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 933246d. Configure here.
Move the footer-hiding selector to the logs page wrapper so it can still reach the global footer after the constrained table layout moved under an extra DOM wrapper. Keep the sticky header structure intact while preserving expanded-table and short-viewport footer hiding. Co-Authored-By: GPT-5.5 <noreply@openai.com> Made-with: Cursor
…e-to-a-sticky-header-layout # Conflicts: # static/app/views/explore/logs/logsTab.tsx
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
nikkikapadia
approved these changes
Apr 27, 2026
Member
nikkikapadia
left a comment
nikkikapadia
left a comment
There was a problem hiding this comment.
lgtm! and thanks for the reminder i'll put this in the errors ui as well 😌
JoshuaKGoldberg
approved these changes
Apr 27, 2026
Member
JoshuaKGoldberg
left a comment
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
This is really snazzy.
...I wonder if we can actually do away with the logs table expando work by standardizing on this scroll behavior? If we're ok with losing the chart visualization on scroll up (I certainly am!) the differences become a lot lesser...
3 tasks
cleptric
pushed a commit
that referenced
this pull request
May 5, 2026
This PR updates the explore page filter level to be sticky, so when users scroll their page filters travel with them. --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: GPT-5.5 <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the explore page filter level to be sticky, so when users scroll their page filters travel with them.
Examples:
Traces
Logs
Application Metrics
