Skip to content

feat(snuba): add sample rate option for span with errors tracking#113785

Merged
constantinius merged 3 commits intomasterfrom
constantinius/feat/snuba/add-option-span-with-errors-ok-sample-rate
Apr 23, 2026
Merged

feat(snuba): add sample rate option for span with errors tracking#113785
constantinius merged 3 commits intomasterfrom
constantinius/feat/snuba/add-option-span-with-errors-ok-sample-rate

Conversation

@constantinius
Copy link
Copy Markdown
Contributor

@constantinius constantinius requested review from a team as code owners April 23, 2026 12:19
@linear-code
Copy link
Copy Markdown

linear-code Bot commented Apr 23, 2026

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 23, 2026
@constantinius constantinius requested a review from a team April 23, 2026 12:19
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit c27bcb0. Configure here.

Comment thread src/sentry/options/defaults.py
Comment thread src/sentry/options/defaults.py
@constantinius constantinius enabled auto-merge (squash) April 23, 2026 12:31
@github-actions
Copy link
Copy Markdown
Contributor

Backend Test Failures

Failures on ad37593 in this run:

tests/snuba/api/endpoints/test_organization_trace.py::OrganizationEventsTraceEndpointTest::test_emits_metric_for_error_on_ok_spanlog
[gw1] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/snuba/api/endpoints/test_organization_trace.py:453: in test_emits_metric_for_error_on_ok_span
    mock_metrics.incr.assert_any_call(
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/unittest/mock.py:1048: in assert_any_call
    raise AssertionError(
E   AssertionError: incr('performance.trace.span_with_errors_ok_status', sample_rate=0.01, tags=<ANY>) call not found

@constantinius constantinius requested a review from a team as a code owner April 23, 2026 12:56
@constantinius constantinius merged commit 169ca2f into master Apr 23, 2026
77 checks passed
@constantinius constantinius deleted the constantinius/feat/snuba/add-option-span-with-errors-ok-sample-rate branch April 23, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants