fix(organizations): Scope delete_organization_member by organization id#113793
Merged
michelletran-sentry merged 1 commit intomasterfrom Apr 23, 2026
Merged
fix(organizations): Scope delete_organization_member by organization id#113793michelletran-sentry merged 1 commit intomasterfrom
michelletran-sentry merged 1 commit intomasterfrom
Conversation
The `delete_organization_member` RPC accepted an `organization_id` argument but never used it — the lookup only filtered by member id, so callers that passed an organization_id mismatching the member's actual organization still triggered a deletion. Include `organization_id` in the `.get()` filter so the method is a no-op (returns False) when the member is not in the supplied organization. Add a regression test covering the accept-invite member-already-exists branch, where the URL-provided member_id belongs to a different organization than the one being accepted. Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Backend
JoshFerge
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
delete_organization_memberRPC accepted anorganization_idargument but never used it — the lookup only filtered by member id, so callers that passed an organization_id mismatching the member's actual organization still triggered a deletion. Includeorganization_idin the.get()filter so the method is a no-op (returns False) when the member is not in the supplied organization.Add a regression test covering the accept-invite member-already-exists branch, where the URL-provided member_id belongs to a different organization than the one being accepted.