feat(replays): add bulk mark-as-viewed button#113805
Merged
JoshuaKGoldberg merged 9 commits intomasterfrom Apr 30, 2026
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
JoshuaKGoldberg
force-pushed
the
replays-bulk-mark-as-viewed
branch
from
bd2c610 to
a9d7f98
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 41a9a59. Configure here.
gggritso
reviewed
Apr 30, 2026
Member
gggritso
left a comment
gggritso
left a comment
There was a problem hiding this comment.
Very cool, just a few nits/questions. Overall this would really benefit from updating the backend to fire these from one network requests, but whatever, that can happen later?
Co-authored-by: George Gritsouk <989898+gggritso@users.noreply.github.com>
Member
Author
Definitely. Tracking: REPLAY-900 |
gggritso
approved these changes
Apr 30, 2026
3 tasks
cleptric
pushed a commit
that referenced
this pull request
May 5, 2026
Adds a new `ReplayBulkViewedActions` component that renders in the header when you have >=0 <'all' Replays selected. It uses the existing viewed-by endpoint to mark each selected Replay as viewed. <table> <thead> <tr> <th>Initial</th> <th>Loading</th> </tr> </thead> <tbody> <tr> <td> <img width="548" height="289" alt="image" src="https://github.com/user-attachments/assets/0f4abec4-091f-4eec-a3f0-6e91fea1fbef" /> </td> <td> <img width="548" height="289" alt="image" src="https://github.com/user-attachments/assets/c093ee90-6106-4ca5-bdfa-bf10246499f9" /> </td> </tr> </tbody> </table> Note that that results in one network request per Replay. I filed REPLAY-898 -> REPLAY-900 to create and use a multi-Replay request endpoint. But someone please correct me, is there a way to do bulk mark-as-viewed already? Renames `QueryKeyValue` to `ListCheckboxQueryKeyRef` so it can be exported and used in the new component props type. This also cleans up `ReturnType<typeof useListItemCheckboxContext>` to a newly exported & named `ListItemCheckboxState`. Fixes REPLAY-894. --------- Co-authored-by: George Gritsouk <989898+gggritso@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new
ReplayBulkViewedActionscomponent that renders in the header when you have >=0 <'all' Replays selected. It uses the existing viewed-by endpoint to mark each selected Replay as viewed.Note that that results in one network request per Replay. I filed REPLAY-898 -> REPLAY-900 to create and use a multi-Replay request endpoint. But someone please correct me, is there a way to do bulk mark-as-viewed already?
Renames
QueryKeyValuetoListCheckboxQueryKeyRefso it can be exported and used in the new component props type. This also cleans upReturnType<typeof useListItemCheckboxContext>to a newly exported & namedListItemCheckboxState.Fixes REPLAY-894.