feat(nav): Lock secondary nav to always be expanded on settings pages#113808
Closed
JonasBa wants to merge 1 commit into
Closed
feat(nav): Lock secondary nav to always be expanded on settings pages#113808JonasBa wants to merge 1 commit into
JonasBa wants to merge 1 commit into
Conversation
When a user navigates to any settings page, the secondary navigation sidebar is now always visible and cannot be collapsed. The collapse toggle button is hidden and the Ctrl+B/Cmd+B keyboard shortcut has no effect while on settings routes. Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Settings pages have structured navigation that users need to browse — collapsing the sidebar here creates a worse experience because it removes the primary way to move between settings sections.
When a user is on any settings route, the secondary sidebar is now always visible regardless of their collapsed preference. The collapse toggle button is hidden, and the Ctrl+B/Cmd+B keyboard shortcut has no effect while on settings routes. When the user navigates away from settings, their previous collapsed/expanded preference is restored.
Implemented by passing the active route group as a prop from
PrimaryNavigationContextProviderdown toSecondaryNavigationContextProvider, where it overrides the view to'expanded'and makessetViewa no-op when the group is'settings'. The header component readsactiveGroupfromusePrimaryNavigation()to conditionally hide the toggle button.