Skip to content

feat(nav): Lock secondary nav to always be expanded on settings pages#113808

Closed
JonasBa wants to merge 1 commit into
masterfrom
jb/settings/collapsible-nav
Closed

feat(nav): Lock secondary nav to always be expanded on settings pages#113808
JonasBa wants to merge 1 commit into
masterfrom
jb/settings/collapsible-nav

Conversation

@JonasBa
Copy link
Copy Markdown
Member

@JonasBa JonasBa commented Apr 23, 2026

Settings pages have structured navigation that users need to browse — collapsing the sidebar here creates a worse experience because it removes the primary way to move between settings sections.

When a user is on any settings route, the secondary sidebar is now always visible regardless of their collapsed preference. The collapse toggle button is hidden, and the Ctrl+B/Cmd+B keyboard shortcut has no effect while on settings routes. When the user navigates away from settings, their previous collapsed/expanded preference is restored.

Implemented by passing the active route group as a prop from PrimaryNavigationContextProvider down to SecondaryNavigationContextProvider, where it overrides the view to 'expanded' and makes setView a no-op when the group is 'settings'. The header component reads activeGroup from usePrimaryNavigation() to conditionally hide the toggle button.

When a user navigates to any settings page, the secondary navigation
sidebar is now always visible and cannot be collapsed. The collapse
toggle button is hidden and the Ctrl+B/Cmd+B keyboard shortcut has
no effect while on settings routes.

Co-Authored-By: Claude <noreply@anthropic.com>
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 23, 2026
@getsantry
Copy link
Copy Markdown
Contributor

getsantry Bot commented May 15, 2026

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry Bot added the Stale label May 15, 2026
@JonasBa JonasBa closed this May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant