Skip to content

fix(autofix): close drawer when navigating outside of current issue#113814

Merged
natemoo-re merged 3 commits intomasterfrom
nm/seer/drawer-urlchange
Apr 24, 2026
Merged

fix(autofix): close drawer when navigating outside of current issue#113814
natemoo-re merged 3 commits intomasterfrom
nm/seer/drawer-urlchange

Conversation

@natemoo-re
Copy link
Copy Markdown
Member

@natemoo-re natemoo-re commented Apr 23, 2026

In this PR, we add a shouldCloseOnLocationChange check—now the drawer remains open when navigating between events/tabs that belong to the current issue, but closes when navigating to a different part of the app.

Previously, the autofix drawer remains open even when navigating to other pages, making the setup process quite frustrating as seen below

CleanShot.2026-04-23.at.16.10.38.mp4

@natemoo-re natemoo-re requested a review from matejminar April 23, 2026 17:15
@natemoo-re natemoo-re marked this pull request as ready for review April 23, 2026 17:15
@natemoo-re natemoo-re requested a review from a team as a code owner April 23, 2026 17:15
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 23, 2026
@priscilawebdev
Copy link
Copy Markdown
Member

What you’re fixing is working. I can confirm that. But shouldn’t the drawer close when you click outside of it? It feels a bit odd that I can interact with other parts of the page while it stays open. It even updates when I click something else that's supposed to open a drawer, and then the UI ends up with that grayish transparent background.

Screen.Recording.2026-04-24.at.09.04.15.mov

@priscilawebdev
Copy link
Copy Markdown
Member

Also noticed that the Seer drawer opens below the top header, while another drawer opens on top of it.

@natemoo-re
Copy link
Copy Markdown
Member Author

@priscilawebdev I don't disagree but I'm going to merge past and we can keep discussing! This behavior is our current convention for Seer, which is being actively iterated on.

Now that we've adopted the drawer into the system, we have two "modes", passive (this one, which acts as a non-blocking sidesheet rendered below the top bar) and blocking (which acts like a traditional modal).

@natemoo-re natemoo-re enabled auto-merge (squash) April 24, 2026 16:22
@natemoo-re natemoo-re merged commit 27c0a83 into master Apr 24, 2026
64 checks passed
@natemoo-re natemoo-re deleted the nm/seer/drawer-urlchange branch April 24, 2026 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants