feat(seer): Add check for seer-gitlab-support in the /seer/onboarding-check/ endpoint#113851
Conversation
…ng-check/ endpoint
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9a6af3b. Configure here.
The signatures of has_supported_scm_integration and is_code_review_enabled were updated to accept Organization objects, but the unit tests still passed integer IDs (self.organization.id). Update all callers to pass the object. Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
Verify three cases for has_supported_scm_integration(): - GitLab integration counts as supported when flag is enabled - No integration still returns False even with flag enabled - GitLab integration does not count without the flag Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
billyvg
left a comment
There was a problem hiding this comment.
just fyi the flag is only enabled for dev orgs atm https://github.com/getsentry/sentry-options-automator/blob/main/options/default/flagpole.yaml#L7790-L7808
|
@cursor merge this PR with master and fixup and broken tests. |
|
Perfect! Now let me update the PR:The PR is already up to date since I pushed the changes. Let me create a summary of what was done: SummaryI successfully merged master into the Changes Made:
The merge resolved the signature mismatch issues that were causing test failures. All test callers in |
- Resolved merge conflict in organization_seer_onboarding_check.py - Added missing features import - Added with_feature decorator import to test file - Kept Organization parameter signature with master's simplified logic Co-authored-by: Ryan Albrecht <ryan@ryanalbrecht.ca>



No description provided.