feat(issues): Record per-branch timings for issue feed EAP double-read#113876
Merged
feat(issues): Record per-branch timings for issue feed EAP double-read#113876
Conversation
…o-query-string' into shashjar/issue-feed-search-eap-implement-eap-group-search
…ch' into shashjar/issue-feed-search-eap-implement-eap-double-read
…o-query-string' into shashjar/issue-feed-search-eap-implement-eap-group-search
…ch' into shashjar/issue-feed-search-eap-implement-eap-double-read
…o-query-string' into shashjar/issue-feed-search-eap-implement-eap-double-read
…o shashjar/make-organization-trace-item-stats-api-endpoint-generic-over-trace-item-type
…t-generic-over-trace-item-type' into shashjar/issue-feed-search-eap-parse-search-filters-into-query-string
…o-query-string' into shashjar/issue-feed-search-eap-implement-eap-double-read
…o-query-string' into shashjar/issue-feed-search-eap-implement-eap-double-read
…o-query-string' into shashjar/issue-feed-search-eap-implement-eap-double-read
…s-api-endpoint-generic-over-trace-item-type
…t-generic-over-trace-item-type' into shashjar/issue-feed-search-eap-parse-search-filters-into-query-string
…s-api-endpoint-generic-over-trace-item-type
…t-generic-over-trace-item-type' into shashjar/issue-feed-search-eap-parse-search-filters-into-query-string
…o-query-string' into shashjar/issue-feed-search-eap-implement-eap-double-read
…h-filters-into-query-string
…o-query-string' into shashjar/issue-feed-search-eap-implement-eap-double-read
…o-query-string' into shashjar/issue-feed-search-eap-implement-eap-double-read
…nce/timing metrics
github-actions
Bot
added
the
Scope: Backend
shashjar
commented
Apr 23, 2026
| # one of the parallel bulk raw queries failed (maybe the issue platform dataset), | ||
| # we'll fallback to querying for errors only | ||
| if GroupCategory.ERROR.value in query_params_for_categories.keys(): | ||
| callsite = "PostgresSnubaQueryExecutor.snuba_search" |
Member
Author
There was a problem hiding this comment.
Review with "Hide whitespace" on
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
thetruecpaul
approved these changes
Apr 27, 2026
…d' into shashjar/issue-feed-search-eap-add-metrics-for-timing
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1f6de65. Configure here.
Base automatically changed from
shashjar/issue-feed-search-eap-implement-eap-double-read
to
master
April 28, 2026 18:01
shashjar
deleted the
shashjar/issue-feed-search-eap-add-metrics-for-timing
branch
3 tasks
cleptric
pushed a commit
that referenced
this pull request
May 5, 2026
#113876) PR 3/3 to implement issue feed search via EAP queries. Follow-up to #112996. Updates the EAP query implementation for issue feed search to capture performance/timing metrics, using the existing `check_and_choose_with_timings` in the `SafeRolloutComparator`. We will now record timings on both the control and experimental branches (both queries provided as thunks), so we can determine the performance impact of using EAP for issue feed search.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 3/3 to implement issue feed search via EAP queries. Follow-up to #112996.
Updates the EAP query implementation for issue feed search to capture performance/timing metrics, using the existing
check_and_choose_with_timingsin theSafeRolloutComparator. We will now record timings on both the control and experimental branches (both queries provided as thunks), so we can determine the performance impact of using EAP for issue feed search.