ref(tsc): move event-timeseries endpoint to apiOptions

[TkDodo]

No description provided.

[JonasBa]

Is this related to type inference, or why do we no longer check for the 0th index truthyness?

[TkDodo]

the result of q.data used to come directly from fetchDataQuery, which returned:

sentry/static/app/api.tsx

Lines 52 to 56 in 8a4f150

	export type ApiResult<Data = any> = [
	data: Data,
	statusText: string | undefined,
	resp: ResponseMeta | undefined,
	];

[0] was the actual data. Now that we use apiOptions, we internally select .json out of it if no select is specified:

sentry/static/app/utils/api/apiOptions.ts

Line 75 in c0479af

select: selectJson,

sentry/static/app/utils/api/apiOptions.ts

Line 44 in c0479af

const selectJson = <TData>(data: ApiResponse<TData>) => data.json;

so q.data is our data, same as q.data[0] was before.

[priscilawebdev]

👏

[priscilawebdev]

We have got 2x enabled props here (top-level enabled and queryOptions.enabled), and the spread order means queryOptions.enabled overwrites the arePageFiltersReady gate. Not introduced by this PR, but worth a follow-up: probably best to drop one of them

[TkDodo]

yes I was confused about this as well 🫠