feat(slack): Unfurl mobile-build dashboard widgets#113939
Merged
DominikB2014 merged 1 commit intomasterfrom Apr 24, 2026
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
Extend Slack dashboard URL unfurling to cover PREPROD_APP_SIZE (mobile build size) widgets. The events-timeseries endpoint already routes dataset=preprodSize through the PreprodSize RPC dataset, so the change is limited to adding the widget-type mapping. Widen _WIDGET_TYPE_TO_DATASET from SupportedTraceItemType values to plain dataset label strings, since "preprodSize" is hardcoded in DATASET_OPTIONS rather than derived from SupportedTraceItemType.PREPROD (which uses the different "preprod" value). Refs DAIN-1573 Co-Authored-By: Claude <noreply@anthropic.com>
DominikB2014
force-pushed
the
dominikbuszowiecki/dain-1573-unfurl-dashboards-mobile-build-dataset-urls
branch
from
e1a76de to
5303e3c
Compare
narsaynorath
approved these changes
Apr 24, 2026
DominikB2014
deleted the
dominikbuszowiecki/dain-1573-unfurl-dashboards-mobile-build-dataset-urls
branch
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #113937 but for mobile builds
Ai Description
Extend Slack dashboard URL unfurling to cover
PREPROD_APP_SIZE(mobile build size) widgets. Previously, onlySPANS,LOGS, andTRACEMETRICSunfurled; links to a mobile-build widget fell into the unsupported-widget skip branch.The
/organizations/{slug}/events-timeseries/endpoint already routesdataset=preprodSizethrough thePreprodSizeRPC dataset (timeseries and top-events both work), and the response shape (TimeSeries[]) is unchanged, so the chart renderer doesn't need to know about this._WIDGET_TYPE_TO_DATASETis widened fromdict[int, SupportedTraceItemType]todict[int, str]because"preprodSize"is hardcoded inDATASET_OPTIONSrather than matchingSupportedTraceItemType.PREPROD.value("preprod"— the endpoint would reject it).Refs DAIN-1573