Skip to content

test(escalating): Skip flaky test_is_forecast_out_of_range#113951

Merged
JoshFerge merged 1 commit intomasterfrom
jferg/skip-flaky-test-is-forecast-out-of-range
Apr 24, 2026
Merged

test(escalating): Skip flaky test_is_forecast_out_of_range#113951
JoshFerge merged 1 commit intomasterfrom
jferg/skip-flaky-test-is-forecast-out-of-range

Conversation

@JoshFerge
Copy link
Copy Markdown
Member

@JoshFerge JoshFerge commented Apr 24, 2026

Skip DailyGroupCountsEscalating.test_is_forecast_out_of_range, which
intermittently fails in CI with (False, None) != (True, 1).

Matches the adjacent test_is_escalating_two_weeks, which is already
skipped as flaky (#94622). Filing as a follow-up so the underlying
escalating-forecast flake can be investigated separately without
keeping CI red.

Agent transcript: https://claudescope.sentry.dev/share/C7E02BqBL8OBDqmebTBImGr1Ina3Tlk4fD03tixw6NM

The test intermittently fails in CI with `(False, None) != (True, 1)`.
Skip it to unblock CI, matching the adjacent test_is_escalating_two_weeks
which is skipped for the same reason.

Co-Authored-By: Claude <noreply@anthropic.com>

Agent transcript: https://claudescope.sentry.dev/share/OTrFh2EhYKCbafh2eOy5N-lC5tnY3YsbpecEEVc-0rc
@JoshFerge JoshFerge requested review from a team as code owners April 24, 2026 17:19
@JoshFerge JoshFerge requested a review from a team April 24, 2026 17:20
@JoshFerge JoshFerge enabled auto-merge (squash) April 24, 2026 17:20
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit b0d36eb. Configure here.

# Events are aggregated in the hourly count query by date rather than the last 24hrs
assert get_group_hourly_count_snuba(group) == (1, False)

@pytest.mark.skip(reason="flaky")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing issue tracker reference in skip reason

Low Severity

The skip reason "flaky" is missing an issue tracker reference. Every other @pytest.mark.skip in this file follows the pattern "flaky: #NNNNN" (e.g., "flaky: #94622", "flaky: #93732", "flaky: #95139"). Without a linked issue number, it becomes harder to track when and why the test was skipped, and to know when it can be re-enabled.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit b0d36eb. Configure here.

@linear-code
Copy link
Copy Markdown

linear-code Bot commented Apr 24, 2026

@JoshFerge JoshFerge merged commit 9d9a3f3 into master Apr 24, 2026
52 checks passed
@JoshFerge JoshFerge deleted the jferg/skip-flaky-test-is-forecast-out-of-range branch April 24, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants