Skip to content

feat(replays): Track event and video event counts on replay load#114001

Merged
gggritso merged 5 commits intomasterfrom
george/replay-video-replayer-metric
Apr 27, 2026
Merged

feat(replays): Track event and video event counts on replay load#114001
gggritso merged 5 commits intomasterfrom
george/replay-video-replayer-metric

Conversation

@gggritso
Copy link
Copy Markdown
Member

@gggritso gggritso commented Apr 24, 2026

Add some Replay telemetry to count the number of segments, especially video segments. Having too many videos (>1,000) seems like it's causing Chrome crashes, and I'd like to both know how often that happens, and be able to find exemplars. This is in support of REPLAY-831

gggritso and others added 5 commits April 24, 2026 18:17
Emit a Sentry metric distribution once per replay load, after all
segments have been fetched, recording the number of video segments the
player received with the project_id as an attribute.

This gives us visibility into the segment-count distribution for mobile
replays in the wild, which is otherwise only answerable via aggregated
Snuba queries against `replays_aggregated`.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Extract replayId, projectId, videoElementCount as locals so the
useEffect can list all its dependencies explicitly. Drop the
eslint-disable and the now-redundant comment.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Extract the metric emission into a useEffectEvent so the useEffect only
needs to depend on replayId and isFetching — the latest videoElementCount,
projectId, and isVideoReplay are read at call time.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Match the JavaScript convention for metric names.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 24, 2026
@gggritso gggritso marked this pull request as ready for review April 24, 2026 22:41
@gggritso gggritso requested a review from a team as a code owner April 24, 2026 22:41
@gggritso gggritso merged commit 969f8b0 into master Apr 27, 2026
68 checks passed
@gggritso gggritso deleted the george/replay-video-replayer-metric branch April 27, 2026 15:33
cleptric pushed a commit that referenced this pull request May 5, 2026
…4001)

Add some Replay telemetry to count the number of segments, especially
video segments. Having too many videos (>1,000) seems like it's causing
Chrome crashes, and I'd like to both know how often that happens, and be
able to find exemplars. This is in support of REPLAY-831

---------

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants