fix(self-hosted): avoid install wizard mail TLS/SSL immutable errors#114011
Open
aldy505 wants to merge 6 commits intogetsentry:masterfrom
Open
fix(self-hosted): avoid install wizard mail TLS/SSL immutable errors#114011aldy505 wants to merge 6 commits intogetsentry:masterfrom
aldy505 wants to merge 6 commits intogetsentry:masterfrom
Conversation
Treat mail.use-tls and mail.use-ssl as a linked pair in the required system options response for the install wizard. If either option is configured on disk with a non-default value, mark both as diskPriority so the wizard does not submit them back through PUT /internal/options/?query=is:required. This avoids the immutable_option failure during first-run setup when self-hosted email settings were already configured in config.yml, including the reported mail.use-tls: true + mail.use-ssl: false case. Add regression coverage for the disk-configured TLS/SSL case and for the control case where both values still match their defaults.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
markstory
approved these changes
Apr 28, 2026
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e2b4563. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes getsentry/self-hosted#4282
Treat mail.use-tls and mail.use-ssl as a linked pair in the required system options response for the install wizard.
If either option is configured on disk with a non-default value, mark both as diskPriority so the wizard does not submit them back through
PUT /internal/options/?query=is:required. This avoids the immutable_option failure during first-run setup when self-hosted email settings were already configured inconfig.yml, including the reportedmail.use-tls: true+mail.use-ssl: falsecase.Add regression coverage for the disk-configured TLS/SSL case and for the control case where both values still match their defaults.