fix(dashboards): Allow wheel widgets to save with null limit#114094
Merged
DominikB2014 merged 1 commit intomasterfrom Apr 28, 2026
Merged
Conversation
Wheel widgets render a single aggregated row and don't use `limit`, but they include grouped columns. The widget serializer required a non-null `limit` for any chart widget with columns that wasn't a TABLE or BIG_NUMBER, which caused saves to fail. Exempt the WHEEL display type from that check. Fixes DAIN-1584 Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Backend
narsaynorath
approved these changes
Apr 28, 2026
DominikB2014
deleted the
dominikbuszowiecki/dain-1584-saving-wheel-widgets-can-fail-with-null-limit
branch
3 tasks
cleptric
pushed a commit
that referenced
this pull request
May 5, 2026
Fixes a bug where the wheel widget failed to save due to "limit is required". Wheel widget don't require a limit, it just queries for aggregates with no group by, so having a limit isn't necessary as there will always be the same number of results. Fixes DAIN-1584 Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where the wheel widget failed to save due to "limit is required". Wheel widget don't require a limit, it just queries for aggregates with no group by, so having a limit isn't necessary as there will always be the same number of results.
Fixes DAIN-1584