Skip to content

feat(supergroups): Sync drawer state to a query param#114116

Merged
scttcper merged 6 commits intomasterfrom
scttcper/supergroup-drawer-url
Apr 28, 2026
Merged

feat(supergroups): Sync drawer state to a query param#114116
scttcper merged 6 commits intomasterfrom
scttcper/supergroup-drawer-url

Conversation

@scttcper
Copy link
Copy Markdown
Member

@scttcper scttcper commented Apr 28, 2026

Opening the supergroup drawer now sets ?supergroupDrawer=<id> on the URL, and loading the page with that param reopens the drawer. Lets you share or refresh into a specific group.

Click and close both replace so the drawer doesn't fill up history. Cold loads fetch the supergroup from the existing single endpoint when it isn't in the warm lookup, so memberList may be missing in that case

Opening the supergroup drawer now sets `?supergroupDrawer=<id>` on the
URL, and loading the page with that param reopens the drawer. Lets you
share or refresh into a specific group.

Click and close both `replace` so the drawer doesn't fill up history.
Cold loads fetch the supergroup from the existing single endpoint when
it isn't in the warm lookup; `memberList` may be missing in that case
so assignee avatars can render without member context, which is fine.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 28, 2026
scttcper and others added 2 commits April 27, 2026 17:20
Skip the fetch and the open-drawer effect when the org doesn't have
top-issues-ui. Also start a replay when the drawer opens.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
drops the manual ref-rebind dance

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
scttcper and others added 2 commits April 27, 2026 17:28
call it once at the page root next to useSuperGroups instead of
inside GroupList

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
The direct supergroup fetch returns a data envelope, but the drawer hook treated it like a bare SupergroupDetail. That left group_ids undefined when opening a drawer from the URL.

Type the endpoint response honestly and pass the unwrapped detail into the drawer.

Co-Authored-By: OpenAI Codex <noreply@openai.com>
@scttcper scttcper marked this pull request as ready for review April 28, 2026 17:38
@scttcper scttcper requested review from a team as code owners April 28, 2026 17:38
@scttcper scttcper merged commit cd6b022 into master Apr 28, 2026
66 checks passed
@scttcper scttcper deleted the scttcper/supergroup-drawer-url branch April 28, 2026 17:54
cleptric pushed a commit that referenced this pull request May 5, 2026
Opening the supergroup drawer now sets `?supergroupDrawer=<id>` on the
URL, and loading the page with that param reopens the drawer. Lets you
share or refresh into a specific group.

Click and close both `replace` so the drawer doesn't fill up history.
Cold loads fetch the supergroup from the existing single endpoint when
it isn't in the warm lookup, so `memberList` may be missing in that case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants