ref(settings): drop legacy FieldGroup in reportUri#114142
Merged
priscilawebdev merged 2 commits intomasterfrom Apr 28, 2026
Merged
ref(settings): drop legacy FieldGroup in reportUri#114142priscilawebdev merged 2 commits intomasterfrom
priscilawebdev merged 2 commits intomasterfrom
Conversation
github-actions
Bot
added
the
Scope: Frontend
ReportUri is a read-only display widget, not a form. The only legacy form import on this file was `FieldGroup` from `sentry/components/forms/fieldGroup`, used solely as a layout wrapper (no label, no help, no validation). Replace it with a scraps `Container` that applies the same xl padding the legacy FieldGroup provided around the TextCopyInput. Panel / PanelHeader / PanelBody / PanelAlert are kept as-is — they are panel primitives, not form components, and they render PanelAlert correctly flush against the panel walls. Swapping to scraps FormFieldGroup was tried but rejected: FormFieldGroup auto-applies padding and a border-bottom to every direct child via a `> *` selector, which double-padded the PanelAlert and added an unwanted divider between the alert and the input. Refs DE-993
priscilawebdev
force-pushed
the
priscila/ref/de-993-migrate-report-uri
branch
from
d2f9736 to
057cff4
Compare
priscilawebdev
changed the title
cleptric
pushed a commit
that referenced
this pull request
May 5, 2026
`ReportUri` is a read-only display widget shared by the CSP, Expect-CT, HPKP and Security Headers index pages. It shows the security report DSN inside a `TextCopyInput`. There is no form submission. The only legacy form import on this file was `FieldGroup` from `sentry/components/forms/fieldGroup`, used purely as a layout wrapper around the `TextCopyInput` (no label, no help, no validation). Swap it for a scraps `Container` with `padding="xl"`, which resolves to `theme.space.xl` on all sides — the exact same value the legacy `FieldGroup` applied. `Panel` / `PanelHeader` / `PanelBody` / `PanelAlert` are kept as-is. They are panel primitives, not form components, and are out of scope for this migration. closes [DE-993](https://linear.app/getsentry/issue/DE-993/migrate-projectsecurityheadersreporturitsx-from-legacy-form-system)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReportUriis a read-only display widget shared by the CSP, Expect-CT, HPKP and Security Headers index pages. It shows the security report DSN inside aTextCopyInput. There is no form submission.The only legacy form import on this file was
FieldGroupfromsentry/components/forms/fieldGroup, used purely as a layout wrapper around theTextCopyInput(no label, no help, no validation). Swap it for a scrapsContainerwithpadding="xl", which resolves totheme.space.xlon all sides — the exact same value the legacyFieldGroupapplied.Panel/PanelHeader/PanelBody/PanelAlertare kept as-is. They are panel primitives, not form components, and are out of scope for this migration.closes DE-993