feat(dashboard): Add overview dashboard #11416
Merged
Merged
Conversation
billyvg
force-pushed
the
feat/dashboard/static-overview-dashboard
branch
7 times, most recently
from
47d6d7b to
85389df
Compare
Member
Author
|
Please review the last commit |
billyvg
force-pushed
the
feat/dashboard/static-overview-dashboard
branch
2 times, most recently
from
e51366c to
53769af
Compare
billyvg
changed the title
billyvg
force-pushed
the
feat/dashboard/static-overview-dashboard
branch
from
53769af to
3622491
Compare
lynnagara
reviewed
Jan 11, 2019
lynnagara
reviewed
Jan 11, 2019
lynnagara
reviewed
Jan 11, 2019
billyvg
force-pushed
the
feat/dashboard/static-overview-dashboard
branch
from
3622491 to
fab1b9e
Compare
Member
|
This looks generally good to me - the only thing I'd ask is if we can pull out the "system queries" stuff from this PR since it's a bit confusing and isn't being used anywhere |
Member
Author
Removed #11494 |
lynnagara
approved these changes
Jan 14, 2019
This adds widgets to the dasboard that is generated by JSON modules.
billyvg
force-pushed
the
feat/dashboard/static-overview-dashboard
branch
from
2c74583 to
4ac1ae4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on
ref(discover): RenamegetChartDataWithPercentagestogetChartDataForWidgets#11434feat(charts): Add props to customize TableChart header and body height #11408feat(discover): Auto-run when there is a query string present #11425