fix(cmdk): Include tags.length in section query key to prevent stale cache#114165
Open
JonasBa wants to merge 1 commit into
Open
fix(cmdk): Include tags.length in section query key to prevent stale cache#114165JonasBa wants to merge 1 commit into
JonasBa wants to merge 1 commit into
Conversation
…cache With staleTime: Infinity, the first cached result would win forever once the section query fired on mount. Tags that arrived later (e.g. when issuePlatformTagsQuery resolved after eventsTagsQuery) would never appear in the "Event Tags" section. Adding tags.length to the queryKey invalidates the cache when the tag list grows, matching the pattern already used in spansCommandPaletteActions.tsx. Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Frontend
priscilawebdev
approved these changes
May 4, 2026
Contributor
|
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tags to queryKey