Skip to content

Fix:Reject options-load when integration is not liked to the group's org#114185

Merged
michelletran-sentry merged 2 commits intomasterfrom
fix/slack-options-load-org-scope
Apr 28, 2026
Merged

Fix:Reject options-load when integration is not liked to the group's org#114185
michelletran-sentry merged 2 commits intomasterfrom
fix/slack-options-load-org-scope

Conversation

@michelletran-sentry
Copy link
Copy Markdown
Contributor

SlackOptionsLoadEndpoint resolved a Group by id and returned the
project's teams and members regardless of whether the requesting
Slack integration was linked to the group's organization. Add an
OrganizationIntegration lookup tying the integration to the group's
organization, mirroring webhooks/action.get_group.

… group's org

SlackOptionsLoadEndpoint resolved a Group by id and returned the
project's teams and members regardless of whether the requesting
Slack integration was linked to the group's organization. Add an
OrganizationIntegration lookup tying the integration to the group's
organization, mirroring webhooks/action.get_group.

GH-20075
…rg link check

Tighten the integration↔organization link lookup to require status=ACTIVE,
so a stale OrganizationIntegration row (PENDING_DELETION, DELETION_IN_PROGRESS,
DISABLED) cannot satisfy the cross-tenant guard during the deletion window.
Switch to get_organization_integrations(..., limit=1) since the singular
helper does not accept a status filter.

GH-20075
@michelletran-sentry michelletran-sentry requested review from a team as code owners April 28, 2026 15:49
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 28, 2026
@michelletran-sentry michelletran-sentry merged commit d9c35ad into master Apr 28, 2026
57 checks passed
@michelletran-sentry michelletran-sentry deleted the fix/slack-options-load-org-scope branch April 28, 2026 17:12
cleptric pushed a commit that referenced this pull request May 5, 2026
…org (#114185)

SlackOptionsLoadEndpoint resolved a Group by id and returned the
project's teams and members regardless of whether the requesting
Slack integration was linked to the group's organization. Add an
OrganizationIntegration lookup tying the integration to the group's
organization, mirroring webhooks/action.get_group.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants