Skip to content

feat(dashboards): Return avatarUrl in dashboard revision createdBy response#114186

Merged
skaasten merged 1 commit intomasterfrom
shaunkaasten/dain-1579-revisions-return-avatar-url
Apr 28, 2026
Merged

feat(dashboards): Return avatarUrl in dashboard revision createdBy response#114186
skaasten merged 1 commit intomasterfrom
shaunkaasten/dain-1579-revisions-return-avatar-url

Conversation

@skaasten
Copy link
Copy Markdown
Contributor

@skaasten skaasten commented Apr 28, 2026

Add the user avatar to the dashboard revision list serializer so it can be displayed by the front end (follow-up PR).

I've tested locally that the front-end still works with this new attribute added.

…sponse

The DashboardRevisionSerializer was returning only id, name, and email for
the createdBy field. Include avatarUrl so callers can display the user's
avatar without constructing it client-side from the email.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@linear-code
Copy link
Copy Markdown

linear-code Bot commented Apr 28, 2026

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 28, 2026
@skaasten skaasten marked this pull request as ready for review April 28, 2026 16:02
@skaasten skaasten requested a review from a team as a code owner April 28, 2026 16:02
@skaasten skaasten merged commit c5392fa into master Apr 28, 2026
60 checks passed
@skaasten skaasten deleted the shaunkaasten/dain-1579-revisions-return-avatar-url branch April 28, 2026 16:19
skaasten added a commit that referenced this pull request Apr 28, 2026
Wire the `avatarUrl` now returned by the revisions API into `UserAvatar`
so the revision list shows the author's avatar instead of always falling
back to initials.

Depends on #114186.

<img width="700" height="149" alt="Screenshot 2026-04-28 at 1 19 11 PM"
src="https://github.com/user-attachments/assets/5812ded5-f530-49f6-bde2-b19124255dec"
/>

Refs #DAIN-1579

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
skaasten added a commit that referenced this pull request Apr 30, 2026
…revision list (#114336)

After #114186, we have the avatar type being returned in the revision
list endpoint.

We should pass that into the avatar component so that it properly shows
initials vs upload vs gravatar.

The current-version row in the modal passes a full `User` object whose
avatar info is nested under `avatar.avatarType`. That field is now
explicitly mapped to the flat `createdBy` prop shape so it follows the
same rendering path as historical revision rows.

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@example.com>
cleptric pushed a commit that referenced this pull request May 5, 2026
…sponse (#114186)

Add the user avatar to the dashboard revision list serializer so it can
be displayed by the front end (follow-up PR).

I've tested locally that the front-end still works with this new
attribute added.

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
cleptric pushed a commit that referenced this pull request May 5, 2026
Wire the `avatarUrl` now returned by the revisions API into `UserAvatar`
so the revision list shows the author's avatar instead of always falling
back to initials.

Depends on #114186.

<img width="700" height="149" alt="Screenshot 2026-04-28 at 1 19 11 PM"
src="https://github.com/user-attachments/assets/5812ded5-f530-49f6-bde2-b19124255dec"
/>

Refs #DAIN-1579

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
cleptric pushed a commit that referenced this pull request May 5, 2026
…revision list (#114336)

After #114186, we have the avatar type being returned in the revision
list endpoint.

We should pass that into the avatar component so that it properly shows
initials vs upload vs gravatar.

The current-version row in the modal passes a full `User` object whose
avatar info is nested under `avatar.avatarType`. That field is now
explicitly mapped to the flat `createdBy` prop shape so it follows the
same rendering path as historical revision rows.

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants