fix(slack): Prefer aggregateField over visualize in explore unfurl#114188
Merged
DominikB2014 merged 4 commits intomasterfrom Apr 28, 2026
Merged
Conversation
When an Explore URL contains both the canonical aggregateField param and the legacy visualize param (e.g. links produced by the dashboards "Open in Explore" flow), the unfurl arg mapper preferred visualize and discarded aggregateField. This caused the events-timeseries request to use the wrong yAxis and to drop the groupBy entirely. Flip the precedence to match the frontend's getSpansAggregateFieldsFromLocation / getLogsAggregateFieldsFromLocation: read aggregateField first, falling back to visualize only when aggregateField is absent. Metrics is unaffected — it parses its own metric JSON param earlier and never reaches this branch. Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Backend
The comment described pre-aggregateField behavior that no longer matches the code below it. Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
…-field-precedence
edwardgou-sentry
approved these changes
Apr 28, 2026
DominikB2014
deleted the
dominik/fix-slack-explore-unfurl-aggregate-field-precedence
branch
DominikB2014
added a commit
that referenced
this pull request
Apr 29, 2026
…unknown (#114334) Fix Slack unfurls of Explore traces URLs that carry an `aggregateSort` referencing a function that isn't in the active `aggregateField` yAxes/groupBys (a stale sort left over from an earlier `visualize` selection). Mirror the frontend's validateAggregateSort Refs #114188 --------- Co-authored-by: Claude <noreply@anthropic.com>
3 tasks
cleptric
pushed a commit
that referenced
this pull request
May 5, 2026
…114188) The explore UI checks against the aggregateField param before the visualize param, updates the chart url unfurl to do the same --------- Co-authored-by: Claude <noreply@anthropic.com>
cleptric
pushed a commit
that referenced
this pull request
May 5, 2026
…unknown (#114334) Fix Slack unfurls of Explore traces URLs that carry an `aggregateSort` referencing a function that isn't in the active `aggregateField` yAxes/groupBys (a stale sort left over from an earlier `visualize` selection). Mirror the frontend's validateAggregateSort Refs #114188 --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The explore UI checks against the aggregateField param before the visualize param, updates the chart url unfurl to do the same