feat(detectors): Cache disabled Detectors in the source-based Detector cache#114193
Merged
feat(detectors): Cache disabled Detectors in the source-based Detector cache#114193
Conversation
github-actions
Bot
added
the
Scope: Backend
saponifi3d
reviewed
Apr 28, 2026
| Detector.objects.filter( | ||
| data_sources__source_id=source_id, | ||
| data_sources__type=query_type, | ||
| enabled=True, |
Contributor
There was a problem hiding this comment.
generally this list is pipped directly into process_detectors -- do we need to filter the list inside of process_detectors or before we invoke anything?
Member
Author
There was a problem hiding this comment.
There's filtering there that has already been deployed, so this should be safe.
saponifi3d
approved these changes
Apr 28, 2026
3 tasks
cleptric
pushed a commit
that referenced
this pull request
May 5, 2026
…r cache (#114193) This broadens the set of cases where the cache can be used including for uptime processing. Part of ISWF-2512.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This broadens the set of cases where the cache can be used including for uptime processing.
Part of ISWF-2512.