Skip to content

fix(dashboards): Filter prebuilt dashboards server-side in add to dashboard modal#114210

Merged
DominikB2014 merged 1 commit intomasterfrom
dominikbuszowiecki/dain-1592-general-dashboard-is-inaccessible-for-new-accounts
Apr 28, 2026
Merged

fix(dashboards): Filter prebuilt dashboards server-side in add to dashboard modal#114210
DominikB2014 merged 1 commit intomasterfrom
dominikbuszowiecki/dain-1592-general-dashboard-is-inaccessible-for-new-accounts

Conversation

@DominikB2014
Copy link
Copy Markdown
Contributor

@DominikB2014 DominikB2014 commented Apr 28, 2026

This fixes a bug where users are seeing the General dashboard in the add to Dashboard modal, but we deprecated that dashboard.

The add-to-dashboard modal previously fetched all dashboards and filtered out
prebuilt entries on the client. For accounts whose dashboard list is dominated
by prebuilt dashboards (notably new accounts), this could leave the dropdown
empty or hide valid dashboards behind pagination. Switch to the existing
excludePrebuilt filter so the API only returns user-owned dashboards.

Fixes DAIN-1592

… dashboard modal

Use the excludePrebuilt filter when fetching dashboards in the add-to-dashboard
modal instead of filtering the response client-side. Prebuilt dashboards cannot
be added to, and filtering on the client meant the dropdown could appear empty
for accounts whose dashboard list is dominated by prebuilt entries.

Fixes DAIN-1592
Co-Authored-By: Claude <noreply@anthropic.com>
@linear-code
Copy link
Copy Markdown

linear-code Bot commented Apr 28, 2026

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 28, 2026
@DominikB2014 DominikB2014 requested a review from a team April 28, 2026 17:53
@DominikB2014 DominikB2014 marked this pull request as ready for review April 28, 2026 17:54
@DominikB2014 DominikB2014 merged commit 8c9d546 into master Apr 28, 2026
67 checks passed
@DominikB2014 DominikB2014 deleted the dominikbuszowiecki/dain-1592-general-dashboard-is-inaccessible-for-new-accounts branch April 28, 2026 18:03
cleptric pushed a commit that referenced this pull request May 5, 2026
…hboard modal (#114210)

This fixes a bug where users are seeing the `General` dashboard in the
`add to Dashboard` modal, but we deprecated that dashboard.

The add-to-dashboard modal previously fetched all dashboards and
filtered out
prebuilt entries on the client. For accounts whose dashboard list is
dominated
by prebuilt dashboards (notably new accounts), this could leave the
dropdown
empty or hide valid dashboards behind pagination. Switch to the existing
`excludePrebuilt` filter so the API only returns user-owned dashboards. 


Fixes DAIN-1592

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants