fix(ci): cap snuba bulk-query thread pool to 4 under per-worker Snuba#114215
Draft
mchen-sentry wants to merge 2 commits into
Draft
fix(ci): cap snuba bulk-query thread pool to 4 under per-worker Snuba#114215mchen-sentry wants to merge 2 commits into
mchen-sentry wants to merge 2 commits into
Conversation
Per-worker Snuba in CI enforces CrossOrgQueryAllocationPolicy with a rejection_threshold of 4 concurrent queries on the errors storage; the default fan-out of 10 in bulk_snuba_queries trips the policy and surfaces flakes. Override the ContextPropagatingThreadPoolExecutor as imported by sentry.utils.snuba so only that module's executor is capped — production code is unmodified, and other modules using the same executor are unaffected.
github-actions
Bot
added
the
Scope: Backend
Contributor
|
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're seeing RateLimitExceeded flakes from CrossOrgQueryAllocationPolicy on the errors storage in CI when bulk_snuba_queries fans out wide (e.g. backfill_supergroups_lightweight). Per-worker Snuba enforces a rejection_threshold of 4 concurrent queries, but the executor in sentry.utils.snuba defaults to max_workers=10. Replacing the previous closed PR (#114105) which added a constant inside snuba.py — this version monkey-patches the executor as imported by sentry.utils.snuba from the pytest plugin only, so production code is untouched and the cap is scoped to that module's executor uses.