ref(snapshots): Final UI tweaks by NicoHinderling · Pull Request #114232 · getsentry/sentry

NicoHinderling · 2026-04-28T20:32:41Z

Summary

Polish pass on the snapshot detail view before merging the TopBar redesign stack:

Header overflow: prevent VCS metadata (branch, SHA, PR, app ID) from wrapping — title row now truncates gracefully while keeping header actions pinned
Keyboard navigation: arrow-up/down keys navigate between snapshots in single view, with a subtle scale press animation on the nav buttons
Layout fix: remove hardcoded maxHeight on the outer container; sidebar height now derives from --top-bar-height CSS var so it works with both old and new page frame

Test plan

Resize the browser narrow enough that the header metadata would previously wrap — confirm it truncates instead
In single-view mode, press arrow-up / arrow-down to navigate snapshots; verify the nav buttons animate on press
Confirm sidebar scrolls correctly under both feature-flagged TopBar and the legacy layout

NicoHinderling · 2026-04-28T20:33:03Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit fff8c76. Configure here.}

Move Card, CardHeader, DarkAware imports to snapshotCards where they actually live. Replace missing GroupContainerRoot with inline Stack. Remove unused getImageGroup and unexport SortBy.

handleKeyDown only animated the nav buttons without actually navigating. Now calls onNavigateSingleView and gates on canNavigatePrev/Next.

The parent handler in snapshots.tsx already navigates on ArrowUp/Down in single view. The child handler in snapshotMainContent.tsx was also calling onNavigateSingleView, causing items to be skipped two at a time. Keep only the pressedDir visual state tracking in the child. Co-Authored-By: Claude <noreply@anthropic.com>

This was referenced Apr 28, 2026

feat(preprod): Update snapshot header with approval actions #113959

Open

ref(preprod): Use transparent color sentinel for overlay visibility #113987

Merged

github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 28, 2026

This was referenced Apr 28, 2026

ref(preprod): Replace sidebar disclosure sections with status filter pills #113988

Merged

feat(preprod): Add SnapshotListView virtualized list component #113992

Open

feat(preprod): Add view mode toggle between single and list views #113993

Open

NicoHinderling mentioned this pull request Apr 28, 2026

feat(preprod): Complete the new snapshot viewer toolbar and controls #113994

Open

NicoHinderling marked this pull request as ready for review April 28, 2026 20:33

NicoHinderling requested a review from a team as a code owner April 28, 2026 20:33

vercel Bot deployed to Preview April 28, 2026 20:34 View deployment

NicoHinderling force-pushed the 04-28-ref_snapshots_final_ui_tweaks branch from 1b0ddf8 to c6a67fd Compare April 28, 2026 22:33

NicoHinderling force-pushed the 04-24-feat_preprod_update_snapshot_header branch from 90f05e3 to 3105d25 Compare April 28, 2026 22:33

vercel Bot deployed to Preview April 28, 2026 22:34 View deployment

NicoHinderling force-pushed the 04-24-feat_preprod_update_snapshot_header branch from 3105d25 to 8ccea91 Compare April 28, 2026 22:49

NicoHinderling force-pushed the 04-28-ref_snapshots_final_ui_tweaks branch from c6a67fd to 2dc9963 Compare April 28, 2026 22:49

vercel Bot deployed to Preview April 28, 2026 22:51 View deployment

vercel Bot deployed to Preview April 28, 2026 23:07 View deployment

cursor Bot reviewed Apr 28, 2026

View reviewed changes

Comment thread static/app/views/preprod/snapshots/main/snapshotMainContent.tsx

vercel Bot deployed to Preview April 28, 2026 23:15 View deployment

NicoHinderling force-pushed the 04-28-ref_snapshots_final_ui_tweaks branch from c63236f to fff8c76 Compare April 28, 2026 23:16

NicoHinderling force-pushed the 04-24-feat_preprod_update_snapshot_header branch from 8ccea91 to 0c55782 Compare April 28, 2026 23:16

sentry Bot reviewed Apr 28, 2026

View reviewed changes

Comment thread static/app/views/preprod/snapshots/main/snapshotMainContent.tsx

vercel Bot deployed to Preview April 28, 2026 23:18 View deployment

sentry Bot reviewed Apr 28, 2026

View reviewed changes

Comment thread static/app/views/preprod/snapshots/main/snapshotMainContent.tsx

cursor Bot reviewed Apr 28, 2026

View reviewed changes

Comment thread static/app/views/preprod/snapshots/main/snapshotMainContent.tsx

NicoHinderling force-pushed the 04-28-ref_snapshots_final_ui_tweaks branch from fff8c76 to 20131ea Compare April 28, 2026 23:44

NicoHinderling force-pushed the 04-24-feat_preprod_update_snapshot_header branch from 0c55782 to 79cf737 Compare April 28, 2026 23:44

vercel Bot deployed to Preview April 28, 2026 23:46 View deployment

NicoHinderling force-pushed the 04-24-feat_preprod_update_snapshot_header branch from 79cf737 to 2c60b73 Compare April 28, 2026 23:46

NicoHinderling force-pushed the 04-28-ref_snapshots_final_ui_tweaks branch from 20131ea to a5bc44d Compare April 28, 2026 23:46

vercel Bot deployed to Preview April 28, 2026 23:49 View deployment

sentry Bot reviewed Apr 28, 2026

View reviewed changes

Comment thread static/app/views/preprod/snapshots/main/snapshotMainContent.tsx

vercel Bot deployed to Preview April 28, 2026 23:56 View deployment

NicoHinderling force-pushed the 04-24-feat_preprod_update_snapshot_header branch from 2c60b73 to 2c31a10 Compare April 29, 2026 00:01

NicoHinderling force-pushed the 04-28-ref_snapshots_final_ui_tweaks branch from af05574 to 6dbda4d Compare April 29, 2026 00:01

vercel Bot deployed to Preview April 29, 2026 00:04 View deployment

NicoHinderling force-pushed the 04-28-ref_snapshots_final_ui_tweaks branch from 6dbda4d to d652c30 Compare April 29, 2026 00:10

NicoHinderling force-pushed the 04-24-feat_preprod_update_snapshot_header branch from 2c31a10 to c08c7ed Compare April 29, 2026 00:10

vercel Bot deployed to Preview April 29, 2026 00:13 View deployment

NicoHinderling force-pushed the 04-24-feat_preprod_update_snapshot_header branch from c08c7ed to 1f8c50a Compare April 29, 2026 00:24

NicoHinderling force-pushed the 04-28-ref_snapshots_final_ui_tweaks branch from d652c30 to d009a31 Compare April 29, 2026 00:24

vercel Bot deployed to Preview April 29, 2026 00:26 View deployment

NicoHinderling and others added 4 commits April 28, 2026 17:27

ref(snapshots): Final UI tweaks

fd2c240

fix(preprod): Fix broken imports and remove unused exports

ee0ca7b

Move Card, CardHeader, DarkAware imports to snapshotCards where they actually live. Replace missing GroupContainerRoot with inline Stack. Remove unused getImageGroup and unexport SortBy.

fix(preprod): Wire keyboard navigation to onNavigateSingleView

e8574bd

handleKeyDown only animated the nav buttons without actually navigating. Now calls onNavigateSingleView and gates on canNavigatePrev/Next.

NicoHinderling force-pushed the 04-24-feat_preprod_update_snapshot_header branch from 1f8c50a to 6a82f94 Compare April 29, 2026 00:28

NicoHinderling force-pushed the 04-28-ref_snapshots_final_ui_tweaks branch from d009a31 to c36a7bf Compare April 29, 2026 00:28

vercel Bot deployed to Preview April 29, 2026 00:29 View deployment

NicoHinderling mentioned this pull request Apr 29, 2026

perf(snapshots): Buffer image swap to eliminate flash during single-view navigation #114271

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ref(snapshots): Final UI tweaks#114232

ref(snapshots): Final UI tweaks#114232
NicoHinderling wants to merge 4 commits into04-24-feat_preprod_update_snapshot_headerfrom
04-28-ref_snapshots_final_ui_tweaks

NicoHinderling commented Apr 28, 2026 •

edited

Loading

Uh oh!

NicoHinderling commented Apr 28, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

NicoHinderling commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

NicoHinderling commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

NicoHinderling commented Apr 28, 2026 •

edited

Loading

NicoHinderling commented Apr 28, 2026 •

edited

Loading