Skip to content

ref(seer-preferences): Remove dual-write and read-from-sentry feature flags and unused Seer API write helpers#114242

Merged
srest2021 merged 4 commits intomasterfrom
ref/seer-preferences-helper-cleanup
Apr 29, 2026
Merged

ref(seer-preferences): Remove dual-write and read-from-sentry feature flags and unused Seer API write helpers#114242
srest2021 merged 4 commits intomasterfrom
ref/seer-preferences-helper-cleanup

Conversation

@srest2021
Copy link
Copy Markdown
Member

@srest2021 srest2021 commented Apr 28, 2026

Fixes AIML-2616, AIML-2614, CW-1175

Depends on #114239, #114240

With all preference write call sites now writing to the Sentry DB directly, the Seer API write helpers are unused and removed. Remove the dual-write and read-from-sentry feature flags as both have been GA'd and are now unused.

…elpers

With all preference write call sites now writing to the Sentry DB directly,
the Seer API write helpers (set_project_seer_preference,
bulk_set_project_preferences, make_set_project_preference_request,
make_bulk_set_project_preferences_request, the request TypedDicts, and
resolve_repository_ids) are unused and removed. The
organizations:seer-project-settings-dual-write feature flag has GA'd and
is dropped from temporary.py.

Tests covering only the deleted helpers are removed.

Land after the endpoint and internal-flow PRs (and the seer cleanup task PR)
to ensure nothing still imports these helpers or references the flag.
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 28, 2026
@linear-code
Copy link
Copy Markdown

linear-code Bot commented Apr 29, 2026

srest2021 and others added 2 commits April 29, 2026 10:26
)

relates to AIML-2614

Follow-up to #114110 which
inlines SeerProjectRepository and ProjectOption cleanup at the call
sites, making these tasks obsolete. Merge after enough deploy cycles
have passed for any in-flight queued tasks to drain.

Drop the task module, its tests, and the celery import registration.

---------

Co-authored-by: Claude <noreply@anthropic.com>
@getsentry getsentry deleted a comment from github-actions Bot Apr 29, 2026
@srest2021 srest2021 changed the title ref(seer): Remove dual-write feature flag and unused Seer API write helpers ref(seer): Remove dual-write and read-from-sentry feature flags and unused Seer API write helpers Apr 29, 2026
@srest2021 srest2021 changed the title ref(seer): Remove dual-write and read-from-sentry feature flags and unused Seer API write helpers ref(seer-preferences): Remove dual-write and read-from-sentry feature flags and unused Seer API write helpers Apr 29, 2026
@srest2021 srest2021 marked this pull request as ready for review April 29, 2026 17:49
@srest2021 srest2021 requested a review from a team as a code owner April 29, 2026 17:49
Copy link
Copy Markdown
Member

@JoshFerge JoshFerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@srest2021 srest2021 merged commit 6304c6d into master Apr 29, 2026
82 checks passed
@srest2021 srest2021 deleted the ref/seer-preferences-helper-cleanup branch April 29, 2026 17:58
cleptric pushed a commit that referenced this pull request May 5, 2026
… flags and unused Seer API write helpers (#114242)

Fixes AIML-2616, AIML-2614, CW-1175

Depends on #114239,
#114240

With all preference write call sites now writing to the Sentry DB
directly, the Seer API write helpers are unused and removed. Remove the
dual-write and read-from-sentry feature flags as both have been GA'd and
are now unused.

---------

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants