Skip to content

feat(explorer): stop polling on api error and show status code in empty state#114273

Merged
aliu39 merged 5 commits intomasterfrom
aliu/stop-poll-on-error
Apr 30, 2026
Merged

feat(explorer): stop polling on api error and show status code in empty state#114273
aliu39 merged 5 commits intomasterfrom
aliu/stop-poll-on-error

Conversation

@aliu39
Copy link
Copy Markdown
Member

@aliu39 aliu39 commented Apr 29, 2026

Right now we poll forever when there's an api error. Stop polling on error and show the status code if it's empty state. It'll be up to the users to trigger refetches (reload page or nav away from the chat and come back).

Also disables new chat button when runId = null instead of empty state, so you can start a new chat from the error state

Screenshot 2026-04-29 at 7 32 11 PM image

@aliu39 aliu39 requested a review from a team as a code owner April 29, 2026 02:41
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 29, 2026
Comment thread static/app/views/seerExplorer/components/emptyState.tsx Outdated
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit b5de474. Configure here.

) => {
if (isError) {
return false;
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error stopping polling falsely triggers "done-thinking" indicator

Low Severity

When an API error occurs while the drawer is closed, isPolling transitions from true to false. The SeerExplorerContextProvider interprets any polling→not-polling transition (while the drawer is closed) as "done-thinking" and shows an accent dot indicator on the Seer button. This gives the user a false signal that the agent completed its work, when it actually errored out. Before this change, errors never stopped polling, so this path was never hit.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit b5de474. Configure here.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

erroring out counts as having an update imo

@aliu39 aliu39 merged commit 74a98e4 into master Apr 30, 2026
69 checks passed
@aliu39 aliu39 deleted the aliu/stop-poll-on-error branch April 30, 2026 02:48
cleptric pushed a commit that referenced this pull request May 5, 2026
…ty state (#114273)

Right now we poll forever when there's an api error. Stop polling on
error and show the status code if it's empty state. It'll be up to the
users to trigger refetches (reload page or nav away from the chat and
come back).

Also disables new chat button when runId = null instead of empty state,
so you can start a new chat from the error state

<img width="703" height="636" alt="Screenshot 2026-04-29 at 7 32 11 PM"
src="https://github.com/user-attachments/assets/ceec988b-592d-4211-92cb-24a74866e86d"
/>
<img width="644" height="366" alt="image"
src="https://github.com/user-attachments/assets/72b97237-691c-4464-988e-ac834f4a1c32"
/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants