chore(explore): Clean up page frame flag#114304
Merged
nsdeschenes merged 7 commits intomasterfrom Apr 29, 2026
Merged
Conversation
Remove useHasPageFrameFeature checks from ExploreContentSection and StarSavedQueryButton, keeping only the page frame code path.
…gs, profiling Remove useHasPageFrameFeature branching from these tab headers, keeping only the TopBar.Slot code path and dropping the legacy Layout.Header fallback.
Remove useHasPageFrameFeature branching from MetricsHeader and MetricsTabFilterSection/MetricsTabBodySection. The add metric/equation buttons and save-as are now always rendered in the filter section.
Remove useHasPageFrameFeature branching from SpansTabHeader and MultiQueryMode, keeping only the TopBar.Slot code path.
Remove useHasPageFrameFeature branching from ReleaseHeader and ReleasesHeader, keeping only the TopBar.Slot code path.
Remove useHasPageFrameFeature branching from replay list, detail, header actions, item dropdown, and list controls. Drops the legacy Layout.Header/FullViewport/ButtonActionsWrapper fallbacks.
Remove useHasPageFrameFeature branching from SavedQueriesView and SavedQueriesLandingContent. The create query button logic that was duplicated in index.tsx is removed since it now lives in the landing content component unconditionally.
github-actions
Bot
added
the
Scope: Frontend
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
narsaynorath
approved these changes
Apr 29, 2026
Member
|
Thank you @nsdeschenes 🙏🏼 |
cleptric
pushed a commit
that referenced
this pull request
May 5, 2026
Saw that there was some cleanup around the page frame flag, so I thought I'd pitch in for the explore pages 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saw that there was some cleanup around the page frame flag, so I thought I'd pitch in for the explore pages 🎉