style(snapshots): Refine snapshot sidebar#114356
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
mtopo27
force-pushed
the
mtopo27/style/snapshot-sidebar-updates
branch
from
bad76a0 to
ce1abd5
Compare
NicoHinderling
force-pushed
the
04-28-perf_snapshots_buffer_image_swap_to_eliminate_flash_during_single-view_navigation
branch
from
f219e4a to
36d7e60
Compare
mtopo27
force-pushed
the
mtopo27/style/snapshot-sidebar-updates
branch
from
ce1abd5 to
5239ba2
Compare
NicoHinderling
force-pushed
the
04-28-perf_snapshots_buffer_image_swap_to_eliminate_flash_during_single-view_navigation
branch
7 times, most recently
from
a5fae76 to
4488ab1
Compare
Base automatically changed from
04-28-perf_snapshots_buffer_image_swap_to_eliminate_flash_during_single-view_navigation
to
master
April 30, 2026 00:41
Add a persistent sidebar divider, remove row separators, and add visual snapshot coverage for the sidebar menu states. Co-Authored-By: OpenAI Codex <noreply@openai.com>
mtopo27
force-pushed
the
mtopo27/style/snapshot-sidebar-updates
branch
from
5239ba2 to
cb77622
Compare
NicoHinderling
approved these changes
Apr 30, 2026
cleptric
pushed a commit
that referenced
this pull request
May 5, 2026
Refine the preprod snapshot sidebar so it has a persistent primary divider and no row separators between menu items. This also adds light and dark visual snapshot coverage for the sidebar menu states we are iterating on. **Sidebar Styling** The sidebar wrapper now owns the right border, while individual rows no longer draw bottom borders. This keeps the menu as a continuous surface while preserving the selected row accent. **Snapshot Coverage** Adds visual snapshots for all-selected, child-selected, and no-results sidebar states across light and dark themes. Stacked on #114271 Co-authored-by: OpenAI Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refine the preprod snapshot sidebar so it has a persistent primary divider and no row separators between menu items. This also adds light and dark visual snapshot coverage for the sidebar menu states we are iterating on.
Sidebar Styling
The sidebar wrapper now owns the right border, while individual rows no longer draw bottom borders. This keeps the menu as a continuous surface while preserving the selected row accent.
Snapshot Coverage
Adds visual snapshots for all-selected, child-selected, and no-results sidebar states across light and dark themes.
Stacked on #114271