Skip to content

fix(skills): Remove billing from control silo references in agent skill docs#114382

Merged
dashed merged 2 commits intomasterfrom
fix/skill-docs-billing-silo-correction
Apr 29, 2026
Merged

fix(skills): Remove billing from control silo references in agent skill docs#114382
dashed merged 2 commits intomasterfrom
fix/skill-docs-billing-silo-correction

Conversation

@dashed
Copy link
Copy Markdown
Member

@dashed dashed commented Apr 29, 2026

Summary

  • Billing transactional data (subscriptions, invoices, charges, payments, promotions) resides in the cell silo, not the control silo
  • Several agent skill docs incorrectly listed billing as a control silo service, which could mislead developers creating new RPC services or silo-annotating models
  • This PR removes the incorrect control-silo references and adds billing to the cell-silo descriptions

Evidence

getsentry billing endpoints are overwhelmingly @cell_silo_endpoint:
payment_create, customer_billing_details, customer_subscription, invoice_index, payment_setup, promotion, promotion_trigger_check, customer_subscription_preview

Billing RPC services (SubscriptionService, PartnerAccountService, HerokuService) are local_mode=CELL.

Only admin/catalog components are control-silo: Plan model (plan definitions), billing_config, admin_billingadmins, Stripe webhook ingress (fans out to cells), notification services.

Changes

Commit 1: Remove incorrect control-silo references

  • hybrid-cloud-rpc/SKILL.md: Removed "billing" from intro paragraph and silo mode decision table control-silo descriptions
  • django-models/SKILL.md: Removed "billing" from control silo model selection guidance

Commit 2: Add billing to cell-silo descriptions

  • hybrid-cloud-rpc/SKILL.md: Added "billing" to cell silo intro paragraph and silo mode decision table

Test plan

  • Verified billing endpoint silo decorators in getsentry (grep -rn cell_silo_endpoint getsentry/api/)
  • Verified billing RPC service local_mode declarations in getsentry
  • Verified billing model silo decorators in getsentry
  • Confirmed no other skill docs have incorrect billing/silo references
  • Confirmed getsentry skill docs are clean (no silo references at all)

…ll docs

Billing endpoints in getsentry are cell-silo (@cell_silo_endpoint), not
control-silo. Several agent skill docs incorrectly listed billing as a
control silo service, which could mislead developers creating new RPC
services or silo-annotating models.

Affected docs:
- hybrid-cloud-rpc/SKILL.md (intro paragraph + silo mode table)
- django-models/SKILL.md (silo selection guidance)
@dashed dashed self-assigned this Apr 29, 2026
Billing models, endpoints, and tasks in getsentry are cell-silo. Explicitly
mention billing in cell silo descriptions so developers know where billing
data lives when creating RPC services or annotating models.
@dashed dashed marked this pull request as ready for review April 29, 2026 22:01
@dashed dashed requested a review from a team as a code owner April 29, 2026 22:01
@dashed dashed requested a review from a team April 29, 2026 22:03
@dashed dashed merged commit ed45c38 into master Apr 29, 2026
49 checks passed
@dashed dashed deleted the fix/skill-docs-billing-silo-correction branch April 29, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants