fix(skills): Remove billing from control silo references in agent skill docs#114382
Merged
fix(skills): Remove billing from control silo references in agent skill docs#114382
Conversation
…ll docs Billing endpoints in getsentry are cell-silo (@cell_silo_endpoint), not control-silo. Several agent skill docs incorrectly listed billing as a control silo service, which could mislead developers creating new RPC services or silo-annotating models. Affected docs: - hybrid-cloud-rpc/SKILL.md (intro paragraph + silo mode table) - django-models/SKILL.md (silo selection guidance)
Billing models, endpoints, and tasks in getsentry are cell-silo. Explicitly mention billing in cell silo descriptions so developers know where billing data lives when creating RPC services or annotating models.
markstory
approved these changes
Apr 29, 2026
cleptric
pushed a commit
that referenced
this pull request
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Evidence
getsentry billing endpoints are overwhelmingly
@cell_silo_endpoint:payment_create,customer_billing_details,customer_subscription,invoice_index,payment_setup,promotion,promotion_trigger_check,customer_subscription_previewBilling RPC services (
SubscriptionService,PartnerAccountService,HerokuService) arelocal_mode=CELL.Only admin/catalog components are control-silo:
Planmodel (plan definitions),billing_config,admin_billingadmins, Stripe webhook ingress (fans out to cells), notification services.Changes
Commit 1: Remove incorrect control-silo references
Commit 2: Add billing to cell-silo descriptions
Test plan
grep -rn cell_silo_endpoint getsentry/api/)local_modedeclarations in getsentry